You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/10/13 14:55:12 UTC

[GitHub] [incubator-streampark] 1996fanrui opened a new pull request, #1834: [Bug] Fix the bug that latest team isn't changed when team is changed

1996fanrui opened a new pull request, #1834:
URL: https://github.com/apache/incubator-streampark/pull/1834

   ## What changes were proposed in this pull request
   
   Issue Number: close #1833 
   
   Fix the bug that latest team isn't changed when team is changed
   
   ## Brief change log
   
   Fix the bug that latest team isn't changed when team is changed
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1834: [Bug] Fix the bug that latest team isn't changed when team is changed

Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #1834:
URL: https://github.com/apache/incubator-streampark/pull/1834#discussion_r994767216


##########
streampark-console/streampark-console-webapp/src/utils/request.js:
##########
@@ -78,7 +78,7 @@ http.interceptors.request.use(config => {
       }
     }
     const teamId = sessionStorage.getItem(TEAM_ID)
-    if (teamId) {
+    if (data['teamId'] == null && teamId) {

Review Comment:
   hi fanrui:
    I don't quite understand, can you explain why you want to change here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys merged pull request #1834: [Bug] Fix the bug that latest team isn't changed when team is changed

Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #1834:
URL: https://github.com/apache/incubator-streampark/pull/1834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] 1996fanrui commented on a diff in pull request #1834: [Bug] Fix the bug that latest team isn't changed when team is changed

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on code in PR #1834:
URL: https://github.com/apache/incubator-streampark/pull/1834#discussion_r994782813


##########
streampark-console/streampark-console-webapp/src/utils/request.js:
##########
@@ -78,7 +78,7 @@ http.interceptors.request.use(config => {
       }
     }
     const teamId = sessionStorage.getItem(TEAM_ID)
-    if (teamId) {
+    if (data['teamId'] == null && teamId) {

Review Comment:
   Hi @wolfboys , thanks for your review. I have update the root cause in the PR description before, you can take a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1834: [Bug] Fix the bug that latest team isn't changed when team is changed

Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #1834:
URL: https://github.com/apache/incubator-streampark/pull/1834#discussion_r994831171


##########
streampark-console/streampark-console-webapp/src/utils/request.js:
##########
@@ -78,7 +78,7 @@ http.interceptors.request.use(config => {
       }
     }
     const teamId = sessionStorage.getItem(TEAM_ID)
-    if (teamId) {
+    if (data['teamId'] == null && teamId) {

Review Comment:
   > Hi @wolfboys , thanks for your review. I have update the root cause in the PR description before, you can take a look.
   
   thx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org