[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner
URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298002733
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/common/Config.java
 ##########
 @@ -483,9 +483,8 @@
      * After dropping database(table/partition), you can recover it by using RECOVER stmt.
      * And this specifies the maximal data retention time. After time, the data will be deleted permanently.
      */
-    // TODO(ygl): temp modify it for test !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
     @ConfField(mutable = true, masterOnly = true)
-    public static long catalog_trash_expire_second = 10L; // 1day
 
 Review comment:
   you can do test by using modify configuration file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org