[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10610: Support alarm metric OP `!=`

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #10610:
URL: https://github.com/apache/skywalking/pull/10610#discussion_r1151618409


##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/OP.java:
##########
@@ -21,28 +21,28 @@
 import static java.util.Objects.requireNonNull;
 
 public enum OP {
-    GREATER {

Review Comment:
   Why do we need to change these? `NOT_EQUAL` seems also working.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org