You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2026/09/07 02:31:53 UTC

[I] [EPIC] Further clean up aggregation implementation [datafusion]

2010YOUY01 opened a new issue, #25006:
URL: https://github.com/apache/datafusion/issues/25006

   ### Is your feature request related to a problem or challenge?
   
   Follows up #22710 
   
   ### Describe the solution you'd like
   
   We have completed the migration functionally in #22710, there are some remaining cleanup items to be done after that:
   
   - [ ] Remove the old implementation in `grouped_hash_stream.rs` after 56.0 release (keep 1 more release in case of major bugs, and we can still use config to switch back)
   - [ ] https://github.com/apache/datafusion/issues/23113
   - [ ] Use builder pattern for constructors: https://github.com/apache/datafusion/pull/23657#discussion_r3626958100
   - [ ] The existing control flow repeatedly construct `Controlflow::Break`, caused large LoC: https://github.com/apache/datafusion/pull/23657#discussion_r3626964015
   - [ ] https://github.com/apache/datafusion/pull/23657#discussion_r3626971239
   - [ ] https://github.com/apache/datafusion/issues/24317
   - [ ] https://github.com/apache/datafusion/issues/24318
   
   For coordination: I plan to do them shortly, but if we're about to ship major features like https://github.com/apache/datafusion/issues/24704, feel free to ping me and I'll pause to avoid conflicts.
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] [EPIC] Further clean up aggregation implementation [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #25006:
URL: https://github.com/apache/datafusion/issues/25006#issuecomment-5586464597

   Nice -- thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org