You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2017/08/17 15:12:45 UTC
[GitHub] activemq-artemis pull request #1469: ARTEMIS-1355 Default config for client ...
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1469
ARTEMIS-1355 Default config for client reconnection attempts does not…
… match documentation
As per docs DEFAULT_RECONNECT_ATTEMPTS should be -1 by default not 0
https://activemq.apache.org/artemis/docs/latest/client-reconnection.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1355
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1469
----
commit 37e1eb23b94193c0e35cc8eeee78280f701ead24
Author: Michael Andre Pearce <mi...@me.com>
Date: 2017-08-17T15:09:11Z
ARTEMIS-1355 Default config for client reconnection attempts does not match documentation
As per docs DEFAULT_RECONNECT_ATTEMPTS should be -1 by default not 0
https://activemq.apache.org/artemis/docs/latest/client-reconnection.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1469: ARTEMIS-1355 Default config for client reconne...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1469
@jbertram you have a very good point. Agreed I will do this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1469: ARTEMIS-1355 Default config for client ...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1469: ARTEMIS-1355 Default config for client reconne...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1469
So this is kind of weird. Awhile back you sent #1438 to "correct" the doc from 0 to -1. Now you're sending this PR to "correct" the code from 0 to -1.
As far as I can tell the original #1438 shouldn't have been merged as it was incorrectly based on the default reconnect-attempts for *cluster-connection*.
The default reconnect-attempts for a normal client connection should be 0 (which it is currently in the code, and used to be in the doc).
I believe this PR should be closed and a new one should be raised to fix what #1438 broke.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---