[jira] [Commented] (MESOS-3329) Unused hashmap::existsValue functions have incomplete code paths

["Neil Conway (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957945#comment-14957945 ] 

Neil Conway commented on MESOS-3329:
------------------------------------

[~vinodkone] Any updates? To me, this patch seems reasonable to commit.

> Unused hashmap::existsValue functions have incomplete code paths
> ----------------------------------------------------------------
>
>                 Key: MESOS-3329
>                 URL: https://issues.apache.org/jira/browse/MESOS-3329
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: Jan Schlicht
>            Assignee: Jian Qiu
>            Priority: Trivial
>              Labels: easyfix, mesosphere
>
> `stout/hashmap.hpp` defines functions `hashmap::existsValue`. These return true if a certain value exists in the hashmap instance. The control flow of these functions doesn't cover the case that the value is not found, which should result in false. Right now the result in this case is undefined.
> As the `existsValue` functions are never called this doesn't result in a compile error atm.
> Possible solutions:
> 1) Add `return false`
> 2) Remove function



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)