You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/27 14:37:26 UTC
[GitHub] [flink] zentol opened a new pull request #11246: [FLINK-16307][e2e]
Use start-cluster.sh instead of manually building cluster
zentol opened a new pull request #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246
Use the `start-cluster.sh` script to start the cluster, instead of manually starting each process. This is more in line with the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592031628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150850769",
"triggerID" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150858795",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
}, {
"hash" : "db7d7f5fe80bc263a7e1ba54bee79601f061bdb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db7d7f5fe80bc263a7e1ba54bee79601f061bdb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 446c719cc0fb9befb41da1e99a10ca0d609778b2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150858795) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703)
* db7d7f5fe80bc263a7e1ba54bee79601f061bdb1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11246: [FLINK-16307][e2e] Use
start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592031628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150850769",
"triggerID" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f113eb99fb1e511769b3a972831e0de6279c8f8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150850769)
* 446c719cc0fb9befb41da1e99a10ca0d609778b2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592031628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150850769",
"triggerID" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150858795",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
}, {
"hash" : "db7d7f5fe80bc263a7e1ba54bee79601f061bdb1",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151055575",
"triggerID" : "db7d7f5fe80bc263a7e1ba54bee79601f061bdb1",
"triggerType" : "PUSH"
}, {
"hash" : "db7d7f5fe80bc263a7e1ba54bee79601f061bdb1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5755",
"triggerID" : "db7d7f5fe80bc263a7e1ba54bee79601f061bdb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db7d7f5fe80bc263a7e1ba54bee79601f061bdb1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151055575) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5755)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#discussion_r385788139
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResource.java
##########
@@ -71,10 +73,8 @@ public void addConfiguration(final Configuration config) throws IOException {
@Override
public ClusterController startCluster(int numTaskManagers) throws IOException {
- distribution.startJobManager();
- for (int x = 0; x < numTaskManagers; x++) {
- distribution.startTaskManager();
- }
+ distribution.setTaskExecutorHosts(IntStream.range(0, numTaskManagers).mapToObj(i -> "localhost").collect(Collectors.toList()));
Review comment:
oh that's handy...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11246: [FLINK-16307][e2e] Use
start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592006202
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4f113eb99fb1e511769b3a972831e0de6279c8f8 (Thu Feb 27 14:56:36 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
azagrebin commented on a change in pull request #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#discussion_r385777809
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResource.java
##########
@@ -71,10 +73,8 @@ public void addConfiguration(final Configuration config) throws IOException {
@Override
public ClusterController startCluster(int numTaskManagers) throws IOException {
- distribution.startJobManager();
- for (int x = 0; x < numTaskManagers; x++) {
- distribution.startTaskManager();
- }
+ distribution.setTaskExecutorHosts(IntStream.range(0, numTaskManagers).mapToObj(i -> "localhost").collect(Collectors.toList()));
Review comment:
```suggestion
distribution.setTaskExecutorHosts(Collections.nCopies(numTaskManagers, "localhost"));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592031628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150850769",
"triggerID" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150858795",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 446c719cc0fb9befb41da1e99a10ca0d609778b2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150858795) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11246: [FLINK-16307][e2e] Use
start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592031628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f113eb99fb1e511769b3a972831e0de6279c8f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592031628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150850769",
"triggerID" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150858795",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f113eb99fb1e511769b3a972831e0de6279c8f8 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/150850769)
* 446c719cc0fb9befb41da1e99a10ca0d609778b2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150858795)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592031628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150850769",
"triggerID" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150858795",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 446c719cc0fb9befb41da1e99a10ca0d609778b2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150858795) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#issuecomment-592031628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150850769",
"triggerID" : "4f113eb99fb1e511769b3a972831e0de6279c8f8",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150858795",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
}, {
"hash" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703",
"triggerID" : "446c719cc0fb9befb41da1e99a10ca0d609778b2",
"triggerType" : "PUSH"
}, {
"hash" : "db7d7f5fe80bc263a7e1ba54bee79601f061bdb1",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151055575",
"triggerID" : "db7d7f5fe80bc263a7e1ba54bee79601f061bdb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 446c719cc0fb9befb41da1e99a10ca0d609778b2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150858795) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5703)
* db7d7f5fe80bc263a7e1ba54bee79601f061bdb1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151055575)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services