You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by afine <gi...@git.apache.org> on 2017/02/15 00:11:17 UTC

[GitHub] zookeeper pull request #178: ZOOKEEPER-2696: Eclipse ant ask no longer deter...

GitHub user afine opened a pull request:

    https://github.com/apache/zookeeper/pull/178

    ZOOKEEPER-2696: Eclipse ant ask no longer determines correct classpath for tests after ZOOKEEPER-2689

    After pulling branch-3.4 i noticed that I could no longer compile and run the tests within my IDE. 
    
    The .classpath file generated by the eclipse ant task was missing necessary dependencies. These missing dependencies all appear to be transitive from dependencies brought in by ZOOKEEPER-2689 (which is why ant is able to run the tests). There were two possible ways to fix this, this patch explicitly lists the new transitive dependencies that are required by our test code. Another solution would be to remove `transitive="false"` from `<ivy:cachepath pathid="junit.path.id" conf="test" transitive="false"/>` in the eclipse target of our `build.xml`. This solution would introduce even more transitive dependencies to the .classpath.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2696

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit bc8d6c35594f24fbb7ebf13066a746f5b7246cd1
Author: Abraham Fine <ab...@cloudera.com>
Date:   2017-02-15T00:03:35Z

    ZOOKEEPER-2696: Eclipse ant ask no longer determines correct classpath after ZOOKEEPER-2689

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #178: ZOOKEEPER-2696: Eclipse ant ask no longer determines c...

Posted by rakeshadr <gi...@git.apache.org>.

Github user rakeshadr commented on the issue:

    https://github.com/apache/zookeeper/pull/178
  
    >> I was able to run the unit tests within eclipse or idea (I used WatcherTest as my example) using just the dependencies I added in the patch.
    
    @afine , Probably, you can run `QuorumKerberosAuthTest.java` test case, which needs all these libraries during execution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #178: ZOOKEEPER-2696: Eclipse ant ask no longer determines c...

Posted by rakeshadr <gi...@git.apache.org>.

Github user rakeshadr commented on the issue:

    https://github.com/apache/zookeeper/pull/178
  
    As per the offline discussion with @afine, identified that `checkstyle ant task` is not working in branch-3.4 and will be raising a new jira task to correct this.
    ```
    checkstyle.check:
    
    set-checkstyle-classpath:
    
    checkstyle:
    [checkstyle] log4j:WARN No appenders could be found for logger (org.apache.commons.beanutils.BeanUtils).
    [checkstyle] log4j:WARN Please initialize the log4j system properly.
    [checkstyle] log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
    
    BUILD FAILED
    $ZK\git\b-3-4-new\build.xml:1595: Unable to create a Checker: cannot initialize module PackageHtml - Unable to instantiate PackageHtml
    ```
    Thanks @afine for the patience. +1 for the simple fix. I will merge this PR to branch-3.4, tomorrow if there is no objection from anyone.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---