[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2128: tools/testbuild.sh: Support the blacklist for the specific host

[GitBox <gi...@apache.org>]

btashton commented on a change in pull request #2128:
URL: https://github.com/apache/incubator-nuttx/pull/2128#discussion_r512933207



##########
File path: tools/testbuild.sh
##########
@@ -258,51 +258,55 @@ function build {
 function dotest {
   echo "===================================================================================="
   config=`echo $1 | cut -d',' -f1`
-  re="-${config/\//:}[[:space:]]"
-  if [[ "${blacklist} " =~ $re ]]; then
-    echo "Skipping: $1"
-  else
-    echo "Configuration/Tool: $1"
-    if [ ${PRINTLISTONLY} -eq 1 ]; then
+  check=-`uname -s`,${config/\//:}

Review comment:
       When I was setting up the windows CI I did this to help ID the system. Maybe we should do the same here since uname is not always exact especially between 32/64bit. Then we also have and explicit list.
   
   ```
   kernel="$(uname -s)"
   case $kernel in
    Linux*) os=Linux;;
    Darwin*) os=Darwin;;
    CYGWIN*) os=Cygwin;;
    MINGW*) os=MinGw;;
    *) os="UNKNOWN:$kernel"
   esac
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org