You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by nickwallen <gi...@git.apache.org> on 2018/05/31 17:24:59 UTC
[GitHub] metron pull request #1042: METRON-1592 Unable to use third party parser with...
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1042
METRON-1592 Unable to use third party parser with Storm versions >= 1.1.0
When launching a third party parser using `$METRON_HOME/bin/start_parser_topology.sh` in HDP 2.6, Storm 1.1.0 the following exception is thrown.
```
ClassNotFoundException: org.apache.metron.parsers.topology.MergeAndShadeTransformer
```
## Changes
* Updated `$METRON_HOME/bin/start_parser_topology.sh` to detect the Storm version.
* When using third party parsers and running a Storm version <1.1.0, the `MergeAndShadeTransformer` is used as it has been.
* When using third party parsers with Storm versions >=1.1.0, the new `--jars` argument is used.
* Updated the third party parsers README as the 'upload to zookeeper' step was out-of-order. Also, corrected some minor formatting issues in the README.
## Testing
* Launch a development environment.
* Ensure that the Alerts UI is being populated with alerts. This confirms that the the default parsers; like Bro and Snort that do not use 3rd party libs can be launched successfully.
* Follow the example instructions in `metron-platform/metron-parsers/3rdPartyParser.md` to deploy a parser that uses a 3rd party library. If the parser can be launched and parse messages, then this change is a success.
* The development environments are based on HDP 2.6 with Storm 1.1.0. If you want a gold star, spin this up in an environment based on HDP 2.5 and ensure that 3rd party parser can be launched.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1592
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1042.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1042
----
commit c53037878987159b15f544349cf92b3f17b7481f
Author: Nick Allen <ni...@...>
Date: 2018-05-31T17:07:36Z
METRON-1592 Unable to use third party parser with Storm versions >= 1.1.0
----
---
[GitHub] metron issue #1042: METRON-1592 Unable to use third party parser with Storm ...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1042
+1 by inspection, this looks great.
---
[GitHub] metron pull request #1042: METRON-1592 Unable to use third party parser with...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1042
---
[GitHub] metron issue #1042: METRON-1592 Unable to use third party parser with Storm ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1042
FYI - I also tested this on Ubuntu just to make sure the script-foo was portable.
---