You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kevin Pilch-Bisson <ke...@pilch-bisson.net> on 2001/02/13 13:47:37 UTC
Re: PATH_MAX problem
Hi Pete,
Sorry about that, I checked it in yesterday. I should be able to fix it
properly, since I believe that APR already finds out the correct path
max value. Give me a few minutes.
On Tue, Feb 13, 2001 at 08:59:15AM -0500, pete collins wrote:
> My build broke this morning on FreeBSD. I think it is a makefile
> problem.
> Anyway, this hack got it to compile.
> I have no idea what the value is supposed to be.
>
> --pete
> Index: target.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_subr/target.c,v
> retrieving revision 1.1
> diff -u -r1.1 target.c
> --- target.c 2001/02/12 18:00:27 1.1
> +++ target.c 2001/02/13 13:30:43
> @@ -24,6 +24,8 @@
> #include "svn_path.h"
> #include "apr_file_info.h"
>
> +#define PATH_MAX 255
> +
>
> /*** Code. ***/
>
--
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net
PGP Public Key At http://pgp.pilch-bisson.net
Re: PATH_MAX problem
Posted by Kevin Pilch-Bisson <ke...@pilch-bisson.net>.
On Tue, Feb 13, 2001 at 05:37:25PM -0800, Greg Stein wrote:
> On Tue, Feb 13, 2001 at 10:40:41AM -0500, Kevin Pilch-Bisson wrote:
> > On Tue, Feb 13, 2001 at 10:58:24AM -0500, pete collins wrote:
> > > I manually addd this to `target.c'
> > >
> > > Is this acceptable? (The number is 255 BTW)
> >
> > Well, sort of. It works as a temporary fix, until the APR stuff is in
> > place. Eventually, (hopefully later today, APR will be able to discover
> > that you have _POSIX_PATH_MAX but not PATH_MAX, and it will define
> > APR_PATH_MAX appropriately. At that point I will change target.c so that
> > it uses APR's stuff.
>
> It's there now.
>
> APR_PATH_MAX
And has been incorporated into SVN since 13 Feb 2001 2:34 EST, according
to ls -l.
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson http://www.pilch-bisson.net
"Historically speaking, the presences of wheels in Unix
has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Re: PATH_MAX problem
Posted by Greg Stein <gs...@lyra.org>.
On Tue, Feb 13, 2001 at 10:40:41AM -0500, Kevin Pilch-Bisson wrote:
> On Tue, Feb 13, 2001 at 10:58:24AM -0500, pete collins wrote:
> > I manually addd this to `target.c'
> >
> > Is this acceptable? (The number is 255 BTW)
>
> Well, sort of. It works as a temporary fix, until the APR stuff is in
> place. Eventually, (hopefully later today, APR will be able to discover
> that you have _POSIX_PATH_MAX but not PATH_MAX, and it will define
> APR_PATH_MAX appropriately. At that point I will change target.c so that
> it uses APR's stuff.
It's there now.
APR_PATH_MAX
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: PATH_MAX problem
Posted by Kevin Pilch-Bisson <ke...@pilch-bisson.net>.
On Tue, Feb 13, 2001 at 10:58:24AM -0500, pete collins wrote:
> I manually addd this to `target.c'
>
> Is this acceptable? (The number is 255 BTW)
Well, sort of. It works as a temporary fix, until the APR stuff is in
place. Eventually, (hopefully later today, APR will be able to discover
that you have _POSIX_PATH_MAX but not PATH_MAX, and it will define
APR_PATH_MAX appropriately. At that point I will change target.c so that
it uses APR's stuff.
>
> Thanks
No, thank you, for finding this problem!
>
> --pete
>
<snip>
> Index: target.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_subr/target.c,v
> retrieving revision 1.1
> diff -u -r1.1 target.c
> --- target.c 2001/02/12 18:00:27 1.1
> +++ target.c 2001/02/13 15:31:27
> @@ -23,6 +23,9 @@
> #include "svn_error.h"
> #include "svn_path.h"
> #include "apr_file_info.h"
> +#include "limits.h"
> +
> +#define PATH_MAX _POSIX_PATH_MAX
>
>
> /*** Code. ***/
--
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net
PGP Public Key At http://pgp.pilch-bisson.net
Re: PATH_MAX problem
Posted by pete collins <pe...@collab.net>.
I manually addd this to `target.c'
Is this acceptable? (The number is 255 BTW)
Thanks
--pete
Kevin Pilch-Bisson wrote:
>
> On Tue, Feb 13, 2001 at 08:47:37AM -0500, Kevin Pilch-Bisson wrote:
> > Hi Pete,
> >
> > Sorry about that, I checked it in yesterday. I should be able to fix it
> > properly, since I believe that APR already finds out the correct path
> > max value. Give me a few minutes.
>
> Actually it may take a little longer, people in APR are working on it,
> but they haven't comitted it yet. I'll keep an eye on things there, and
> fix this as soon as it becomes feasible. I don't think it is worth
> duplicating their effort for a short period of time.
>
> In the mean time though, you could try
> #define PATH_MAX _POSIX_PATH_MAX
> if you have _POSIX_PATH_MAX. If not, can you send me the man page from
> your system for realpath(3)?
>
> Thanks, and sorry about the inconvenience.
>
> >
> > On Tue, Feb 13, 2001 at 08:59:15AM -0500, pete collins wrote:
> > > My build broke this morning on FreeBSD. I think it is a makefile
> > > problem.
> > > Anyway, this hack got it to compile.
> > > I have no idea what the value is supposed to be.
> > >
> > > --pete
> > > Index: target.c
> > > ===================================================================
> > > RCS file: /cvs/subversion/subversion/libsvn_subr/target.c,v
> > > retrieving revision 1.1
> > > diff -u -r1.1 target.c
> > > --- target.c 2001/02/12 18:00:27 1.1
> > > +++ target.c 2001/02/13 13:30:43
> > > @@ -24,6 +24,8 @@
> > > #include "svn_path.h"
> > > #include "apr_file_info.h"
> > >
> > > +#define PATH_MAX 255
> > > +
> > >
> > > /*** Code. ***/
> > >
>
> --
> >~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Kevin Pilch-Bisson
> kevin@pilch-bisson.net
> http://www.pilch-bisson.net
> PGP Public Key At http://pgp.pilch-bisson.net
>
> ------------------------------------------------------------------------
> Part 1.2Type: application/pgp-signature
Re: PATH_MAX problem
Posted by Kevin Pilch-Bisson <ke...@pilch-bisson.net>.
On Tue, Feb 13, 2001 at 08:47:37AM -0500, Kevin Pilch-Bisson wrote:
> Hi Pete,
>
> Sorry about that, I checked it in yesterday. I should be able to fix it
> properly, since I believe that APR already finds out the correct path
> max value. Give me a few minutes.
Actually it may take a little longer, people in APR are working on it,
but they haven't comitted it yet. I'll keep an eye on things there, and
fix this as soon as it becomes feasible. I don't think it is worth
duplicating their effort for a short period of time.
In the mean time though, you could try
#define PATH_MAX _POSIX_PATH_MAX
if you have _POSIX_PATH_MAX. If not, can you send me the man page from
your system for realpath(3)?
Thanks, and sorry about the inconvenience.
>
> On Tue, Feb 13, 2001 at 08:59:15AM -0500, pete collins wrote:
> > My build broke this morning on FreeBSD. I think it is a makefile
> > problem.
> > Anyway, this hack got it to compile.
> > I have no idea what the value is supposed to be.
> >
> > --pete
> > Index: target.c
> > ===================================================================
> > RCS file: /cvs/subversion/subversion/libsvn_subr/target.c,v
> > retrieving revision 1.1
> > diff -u -r1.1 target.c
> > --- target.c 2001/02/12 18:00:27 1.1
> > +++ target.c 2001/02/13 13:30:43
> > @@ -24,6 +24,8 @@
> > #include "svn_path.h"
> > #include "apr_file_info.h"
> >
> > +#define PATH_MAX 255
> > +
> >
> > /*** Code. ***/
> >
--
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net
PGP Public Key At http://pgp.pilch-bisson.net