You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2020/05/05 12:49:00 UTC
Minor fix on gitHub actions build
Hello Bookkeepers,
I would like to commit this little patch that improves GitHub Actions.
https://github.com/apache/bookkeeper/pull/2323
I am looking for a +1.
Matteo Minardi already approved it.
I wonder if for this kind of small patches that do not have an impact over
code it is possible to simply commit them just given another +1 from a
non-committer, but "known contributor".
Thoughts ?
Enrico
Re: Minor fix on gitHub actions build
Posted by Yong Zhang <zh...@gmail.com>.
Sorry about that. I misunderstood.
On Fri, 8 May 2020 at 20:37, Enrico Olivelli - Diennea
<en...@diennea.com.invalid> wrote:
> Thank you Yong
> But I am not sure what's your LGTM for
>
> My question is:
> I wonder if for this kind of small patches that do not have an impact
> over code it is possible to simply commit them just given another +1 from
> a non-committer, but "known contributor".
>
>
> Enrico
>
>
> Il giorno 08/05/20, 14:35 "Yong Zhang" <zh...@gmail.com> ha
> scritto:
>
> LGTM.
>
> Yong
>
> On Fri, 8 May 2020 at 20:26, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Thoughts ?
> >
> > Enrico
> >
> > Il giorno mar 5 mag 2020 alle ore 14:49 Enrico Olivelli <
> > eolivelli@gmail.com>
> > ha scritto:
> >
> > > Hello Bookkeepers,
> > > I would like to commit this little patch that improves GitHub
> Actions.
> > >
> > > https://github.com/apache/bookkeeper/pull/2323
> > >
> > > I am looking for a +1.
> > >
> > > Matteo Minardi already approved it.
> > > I wonder if for this kind of small patches that do not have an
> impact
> > over
> > > code it is possible to simply commit them just given another +1
> from a
> > > non-committer, but "known contributor".
> > >
> > >
> > > Thoughts ?
> > > Enrico
> > >
> >
>
>
> ________________________________
>
> CONFIDENTIALITY & PRIVACY NOTICE
> This e-mail (including any attachments) is strictly confidential and may
> also contain privileged information. If you are not the intended recipient
> you are not authorised to read, print, save, process or disclose this
> message. If you have received this message by mistake, please inform the
> sender immediately and destroy this e-mail, its attachments and any copies.
> Any use, distribution, reproduction or disclosure by any person other than
> the intended recipient is strictly prohibited and the person responsible
> may incur in penalties.
> The use of this e-mail is only for professional purposes; there is no
> guarantee that the correspondence towards this e-mail will be read only by
> the recipient, because, under certain circumstances, there may be a need to
> access this email by third subjects belonging to the Company.
>
Re: Minor fix on gitHub actions build
Posted by Enrico Olivelli - Diennea <en...@diennea.com.INVALID>.
Thank you Yong
But I am not sure what's your LGTM for
My question is:
I wonder if for this kind of small patches that do not have an impact over code it is possible to simply commit them just given another +1 from a non-committer, but "known contributor".
Enrico
Il giorno 08/05/20, 14:35 "Yong Zhang" <zh...@gmail.com> ha scritto:
LGTM.
Yong
On Fri, 8 May 2020 at 20:26, Enrico Olivelli <eo...@gmail.com> wrote:
> Thoughts ?
>
> Enrico
>
> Il giorno mar 5 mag 2020 alle ore 14:49 Enrico Olivelli <
> eolivelli@gmail.com>
> ha scritto:
>
> > Hello Bookkeepers,
> > I would like to commit this little patch that improves GitHub Actions.
> >
> > https://github.com/apache/bookkeeper/pull/2323
> >
> > I am looking for a +1.
> >
> > Matteo Minardi already approved it.
> > I wonder if for this kind of small patches that do not have an impact
> over
> > code it is possible to simply commit them just given another +1 from a
> > non-committer, but "known contributor".
> >
> >
> > Thoughts ?
> > Enrico
> >
>
________________________________
CONFIDENTIALITY & PRIVACY NOTICE
This e-mail (including any attachments) is strictly confidential and may also contain privileged information. If you are not the intended recipient you are not authorised to read, print, save, process or disclose this message. If you have received this message by mistake, please inform the sender immediately and destroy this e-mail, its attachments and any copies. Any use, distribution, reproduction or disclosure by any person other than the intended recipient is strictly prohibited and the person responsible may incur in penalties.
The use of this e-mail is only for professional purposes; there is no guarantee that the correspondence towards this e-mail will be read only by the recipient, because, under certain circumstances, there may be a need to access this email by third subjects belonging to the Company.
Re: Minor fix on gitHub actions build
Posted by Yong Zhang <zh...@gmail.com>.
LGTM.
Yong
On Fri, 8 May 2020 at 20:26, Enrico Olivelli <eo...@gmail.com> wrote:
> Thoughts ?
>
> Enrico
>
> Il giorno mar 5 mag 2020 alle ore 14:49 Enrico Olivelli <
> eolivelli@gmail.com>
> ha scritto:
>
> > Hello Bookkeepers,
> > I would like to commit this little patch that improves GitHub Actions.
> >
> > https://github.com/apache/bookkeeper/pull/2323
> >
> > I am looking for a +1.
> >
> > Matteo Minardi already approved it.
> > I wonder if for this kind of small patches that do not have an impact
> over
> > code it is possible to simply commit them just given another +1 from a
> > non-committer, but "known contributor".
> >
> >
> > Thoughts ?
> > Enrico
> >
>
Re: Minor fix on gitHub actions build
Posted by Enrico Olivelli <eo...@gmail.com>.
Thoughts ?
Enrico
Il giorno mar 5 mag 2020 alle ore 14:49 Enrico Olivelli <eo...@gmail.com>
ha scritto:
> Hello Bookkeepers,
> I would like to commit this little patch that improves GitHub Actions.
>
> https://github.com/apache/bookkeeper/pull/2323
>
> I am looking for a +1.
>
> Matteo Minardi already approved it.
> I wonder if for this kind of small patches that do not have an impact over
> code it is possible to simply commit them just given another +1 from a
> non-committer, but "known contributor".
>
>
> Thoughts ?
> Enrico
>