You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Kenneth Knowles (JIRA)" <ji...@apache.org> on 2019/01/15 20:05:00 UTC

[jira] [Created] (BEAM-6441) cut_release_branch.sh should not push to master without verification and a PR

Kenneth Knowles created BEAM-6441:
-------------------------------------

             Summary: cut_release_branch.sh should not push to master without verification and a PR
                 Key: BEAM-6441
                 URL: https://issues.apache.org/jira/browse/BEAM-6441
             Project: Beam
          Issue Type: Bug
          Components: build-system
            Reporter: Kenneth Knowles
            Assignee: Kenneth Knowles


Currently, the cut_release_branch.sh does many things:

 - Edits files in place to update the version
 - Makes a local commit
 - Pushing the local commit to master
 - Creates a new branch
 - Edits files in place to update the version
 - Pushes the release branch

I think all of this except the push to master are OK. It is possible that we have something - website, examples, new places where the version is hardcoded, etc, that get broken in this process. Moving from x-SNAPSHOT to (x+1)-SNAPSHOT is easy to do in a pull request and safe. The release branch creation does not need to be synchronized with this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)