You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Christopher Schuck <cs...@stny.rr.com> on 2004/04/04 03:40:49 UTC
[math] Question regarding submitting patches
I have some minor patches (javadoc) to submit for this project, but I
have not been successful in creating the unified diff file from CVS. I
tried the following:
cvs -d :pserver:anoncvs@cvs.apache.org:/home/cvspublic login password:
anoncvs
export CVSROOT=:pserver:anoncvs:anoncvs@cvs.apache.org:/home/cvspublic
cvs diff -u MathUtils.java
but with no success. Other variations with the -d option, and attempts
to specify a path failed. I was in the directory where the
MathUtils.java file was located on my local system. I am new to using
CVS, and I can well guess I am missing something (perhaps a lot) here,
any help would be appreciated.
--
Christopher Schuck
"If you have no voice, SCREAM; if you have no legs, RUN; if you have no hope, INVENT" - Alegria
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [math] Question regarding submitting patches
Posted by Christopher Schuck <cs...@stny.rr.com>.
Phil Steitz wrote:
> Great start! One thing that would be useful, and a good general
> practice, would be to include a test case that shows the error that
> you are fixing. I notice that there are no test cases for the
> indicator functions :-( in MathUtilsTest. A patch adding these would
> be most welcome ;-)
Phil, I greatly appreciate the encouragement and help. I'll look at
adding in those tests this week, I have some familiarity with JUnit
tests, so I don't think it will take long.
--
Christopher Schuck
"If you have no voice, SCREAM; if you have no legs, RUN; if you have no hope, INVENT" - Alegria
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [math] Question regarding submitting patches
Posted by Phil Steitz <ph...@steitz.com>.
Christopher Schuck wrote:
> Hi Phil,
>
> Thank you, I guessed I was missing a step somewhere, doing what you said
> took care of the problem. I submitted the patches, if that isn't what
> you're looking for, let me know, I'll fix it if necessary. I know this
> isn't a whole lot to contribute, but it was a place to start.
>
Great start! One thing that would be useful, and a good general practice,
would be to include a test case that shows the error that you are
fixing. I notice that there are no test cases for the indicator functions
:-( in MathUtilsTest. A patch adding these would be most welcome ;-)
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [math] Question regarding submitting patches
Posted by Christopher Schuck <cs...@stny.rr.com>.
Hi Phil,
Thank you, I guessed I was missing a step somewhere, doing what you said
took care of the problem. I submitted the patches, if that isn't what
you're looking for, let me know, I'll fix it if necessary. I know this
isn't a whole lot to contribute, but it was a place to start.
I bookmarked both sites you mention in your reply, and also purchased
the O'Reilly text, Essential CVS.
Phil Steitz wrote:
> Looks like you forgot to checkout the module first.
>
> You need to do
>
> cvs co jakarta-commons/math
>
> after the cvs login and CVSROOT export.
>
> That will create a local cvs sandbox for you. Find the files that you
> want to patch in your newly created local jakarta-commons/math, make
> your changes and then run the diff from the sandbox directory where
> the modified files reside.
>
> See http://www.apache.org/dev/version-control.html
>
> In addition to the CVS homepage referenced there, here is another CVS
> reference that I like:
>
> http://cvsbook.red-bean.com/cvsbook.html
>
> Thanks in advance for the patches!
>
> Phil
--
Christopher Schuck
"If you have no voice, SCREAM; if you have no legs, RUN; if you have no hope, INVENT" - Alegria
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [math] Question regarding submitting patches
Posted by Phil Steitz <ph...@steitz.com>.
Hi Chris,
Looks like you forgot to checkout the module first.
You need to do
cvs co jakarta-commons/math
after the cvs login and CVSROOT export.
That will create a local cvs sandbox for you. Find the files that you want
to patch in your newly created local jakarta-commons/math, make your
changes and then run the diff from the sandbox directory where the
modified files reside.
See http://www.apache.org/dev/version-control.html
In addition to the CVS homepage referenced there, here is another CVS
reference that I like:
http://cvsbook.red-bean.com/cvsbook.html
Thanks in advance for the patches!
Phil
Christopher Schuck wrote:
> I have some minor patches (javadoc) to submit for this project, but I
> have not been successful in creating the unified diff file from CVS. I
> tried the following:
>
> cvs -d :pserver:anoncvs@cvs.apache.org:/home/cvspublic login password:
> anoncvs
>
> export CVSROOT=:pserver:anoncvs:anoncvs@cvs.apache.org:/home/cvspublic
>
> cvs diff -u MathUtils.java
>
> but with no success. Other variations with the -d option, and attempts
> to specify a path failed. I was in the directory where the
> MathUtils.java file was located on my local system. I am new to using
> CVS, and I can well guess I am missing something (perhaps a lot) here,
> any help would be appreciated.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org