You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@crunch.apache.org by "Josh Wills (JIRA)" <ji...@apache.org> on 2013/01/30 15:53:13 UTC

[jira] [Updated] (CRUNCH-157) Mark the setContext function in the DoFn class as final

     [ https://issues.apache.org/jira/browse/CRUNCH-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Wills updated CRUNCH-157:
------------------------------

    Attachment: CRUNCH-157.patch

Patch attached-- it turns out the only instances that needed to be fixed for this were the FilterFns (and/or/not).
                
> Mark the setContext function in the DoFn class as final
> -------------------------------------------------------
>
>                 Key: CRUNCH-157
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-157
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>         Attachments: CRUNCH-157.patch
>
>
> We often use a pattern of nested DoFns-- DoFns that are composed of operations on other DoFns. There is currently an ambiguity around the right way to initialize those DoFns, since it can be done either via overriding the initialize() or the setContext() methods in DoFn. We should mark setContext as final in order to remove the ambiguity and fix the instances in Crunch core where we override setContext() instead of initialize().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira