You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/11 04:05:33 UTC

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1208: [HUDI-304] Bring back spotless plugin

leesf commented on a change in pull request #1208: [HUDI-304] Bring back spotless plugin
URL: https://github.com/apache/incubator-hudi/pull/1208#discussion_r365497747
 
 

 ##########
 File path: style/checkstyle.xml
 ##########
 @@ -61,10 +61,11 @@
             <property name="allowByTailComment" value="true"/>
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
+        <!-- when use mvn spotless:apply to format code, the length would be more than 120, even 200.
         <module name="LineLength">
-            <property name="max" value="200"/>
+            <property name="max" value="120"/>
             <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
-        </module>
+        </module>-->
 
 Review comment:
   Comment it intentionally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services