[GitHub] [pulsar] eolivelli commented on a change in pull request #14097: Consumer not able to consume message outside of a transaction if `enableTransaction=false` (client) and `TransactionCoordinatorEnabled=true` (broker) after 2.9.0

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #14097:
URL: https://github.com/apache/pulsar/pull/14097#discussion_r801038311



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -174,6 +174,9 @@ public void recoverExceptionally(Exception e) {
     @Override
     public CompletableFuture<Void> checkIfTBRecoverCompletely(boolean isTxnEnabled) {
         if (!isTxnEnabled) {
+            if (!changeToNoSnapshotState()) {
+                log.error("[{}]Transaction buffer recover fail with transaction disabled", topic.getName());

Review comment:
       One question...why aren't we failing the request?
   The system is broken




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org