You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/01 04:00:47 UTC
[GitHub] [shardingsphere] TeslaCN opened a new pull request, #21877: Make SQLStatementContext always present in ServerPreparedStatement
TeslaCN opened a new pull request, #21877:
URL: https://github.com/apache/shardingsphere/pull/21877
Related to #21574.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #21877: Make SQLStatementContext always present in ServerPreparedStatement
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #21877:
URL: https://github.com/apache/shardingsphere/pull/21877#discussion_r1010202021
##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/session/ServerPreparedStatement.java:
##########
@@ -35,16 +32,9 @@ public interface ServerPreparedStatement {
String getSql();
/**
- * Get {@link SQLStatement} of server prepared statement.
- *
- * @return {@link SQLStatement}
- */
- SQLStatement getSqlStatement();
-
- /**
- * Get optional {@link SQLStatementContext} of server prepared statement.
+ * Get {@link SQLStatementContext} of server prepared statement.
*
- * @return optional {@link SQLStatementContext}
+ * @return {@link SQLStatementContext}
*/
- Optional<SQLStatementContext<?>> getSqlStatementContext();
+ SQLStatementContext<?> getSqlStatementContext();
Review Comment:
Now the SQLStatementContext is always present in ServerPreparedStatement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #21877: Make SQLStatementContext always present in ServerPreparedStatement
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #21877:
URL: https://github.com/apache/shardingsphere/pull/21877#discussion_r1010201746
##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/session/ServerPreparedStatement.java:
##########
@@ -35,16 +32,9 @@ public interface ServerPreparedStatement {
String getSql();
/**
- * Get {@link SQLStatement} of server prepared statement.
- *
- * @return {@link SQLStatement}
- */
- SQLStatement getSqlStatement();
-
- /**
- * Get optional {@link SQLStatementContext} of server prepared statement.
+ * Get {@link SQLStatementContext} of server prepared statement.
*
- * @return optional {@link SQLStatementContext}
+ * @return {@link SQLStatementContext}
*/
- Optional<SQLStatementContext<?>> getSqlStatementContext();
Review Comment:
Now the `SQLStatementContext` is always present in `ServerPreparedStatement`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21877: Make SQLStatementContext always present in ServerPreparedStatement
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21877:
URL: https://github.com/apache/shardingsphere/pull/21877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org