You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Robert Kanter <rk...@cloudera.com> on 2013/03/14 22:44:42 UTC
Review Request: OOZIE-1118 (improve logic of purge service)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1456690
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1456690
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1456690
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/#review18002
-----------------------------------------------------------
approach looks ok, collection of items to delete seems wrong.
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment38029>
if a wf has more subwfs that the limit, those exceeding the limit will become orphans and will never be cleaned.
if a subwf as a subwf itself, those sub-sub-wf will become orphans a will never be cleaned.
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment38030>
if you are limiting the wf you load for a coord,then those exceeding the limit will become orphan and they won't be cleaned ever.
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment38031>
again, limit problem
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment38032>
again limit problem
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment38033>
again limit problem
- Alejandro Abdelnur
On March 15, 2013, 10:17 p.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9942/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 10:17 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Patch for OOZIE-1118 (improve logic of purge service)
>
> See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
>
> These files are deleted, but I didn't end up in the patch on RB for some reason:
> - BulkDeleteForPurgeJPAExecutor.java
> - TestBulkDeleteForPurgeJPAExecutor.java
> - BundlePurgeXCommand.java
> - CoordPurgeXCommand.java
> - wf/PurgeXCommand.java
> - TestBundlePurgeXCommand.java
> - TestCoordPurgeXCommand.java
> - wf/TestPurgeXCommand.java
>
>
> This addresses bug OOZIE-1118.
> https://issues.apache.org/jira/browse/OOZIE-1118
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1456690
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1456690
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1456690
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1456690
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1456690
> trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1456690
> trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1456690
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1456690
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1456690
>
> Diff: https://reviews.apache.org/r/9942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Kanter
>
>
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/#review18405
-----------------------------------------------------------
Looks good..two comments.
I have not looked at the code very closely. As tucu was already reviewing it, you can get +1 from him before committing.
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java
<https://reviews.apache.org/r/9942/#comment38604>
another terminal state is DONEWITHERROR
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java
<https://reviews.apache.org/r/9942/#comment38605>
a minor comment..
A 'NOT IN terminal state' query
will be simple
where w.status NOT IN (SUCCEEDED, FAILED, KILLED, DONEWITHERRO)
- Virag Kothari
On March 25, 2013, 7:55 p.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9942/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 7:55 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Patch for OOZIE-1118 (improve logic of purge service)
>
> See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
>
>
> This addresses bug OOZIE-1118.
> https://issues.apache.org/jira/browse/OOZIE-1118
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1460860
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1460860
>
> Diff: https://reviews.apache.org/r/9942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Kanter
>
>
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/#review18707
-----------------------------------------------------------
Ship it!
LGTM, Nice job
- Alejandro Abdelnur
On April 4, 2013, 10:35 p.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9942/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 10:35 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Patch for OOZIE-1118 (improve logic of purge service)
>
> See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
>
>
> This addresses bug OOZIE-1118.
> https://issues.apache.org/jira/browse/OOZIE-1118
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1464779
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1464779
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1464779
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464779
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1464779
> trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1464779
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1464779
> trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1464779
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1464779
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1464779
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1464779
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1464779
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1464779
> trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1464779
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1464779
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1464779
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1464779
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1464779
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1464779
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1464779
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1464779
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1464779
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1464779
>
> Diff: https://reviews.apache.org/r/9942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Kanter
>
>
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated April 4, 2013, 10:35 p.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1464779
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1464779
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1464779
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464779
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1464779
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1464779
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1464779
trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1464779
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1464779
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1464779
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1464779
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1464779
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1464779
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1464779
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1464779
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1464779
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1464779
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1464779
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1464779
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1464779
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1464779
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1464779
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1464779
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
> On April 4, 2013, 12:07 a.m., Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java, line 300
> > <https://reviews.apache.org/r/9942/diff/9/?file=274750#file274750line300>
> >
> > same as purgeWF
>
> Robert Kanter wrote:
> Because coordinators can't have other Coords as children (i.e. no dependencies between them), we can actually delete them in any order; I only did it like this because I had to for WFs. So, I think you're right that it would be simpler to do this in a forward loop by chunks (though we don't need to do Collections.reverse() on it).
Actually, looking at it more, I don't think doing the indexing the way you suggested will work properly (or at least not without some additional if statements). But I can make what I have here go forward instead of backward
> On April 4, 2013, 12:07 a.m., Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java, line 284
> > <https://reviews.apache.org/r/9942/diff/9/?file=274750#file274750line284>
> >
> > wouldn't be easier to Collections.reverse() the list and then do a forward loop by chunks ?
> >
> > for (int i = 0; i < wf.size(); i += limit) {
> > delete(i*limit, (i+1)*limit);
> > }
> > delete((i-1)*limit, wf.size())
> >
I'll do a Collections.reverse(), but I think I should keep the existing "style" of looping (see next comment)
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/#review18677
-----------------------------------------------------------
On March 27, 2013, 12:18 a.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9942/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 12:18 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Patch for OOZIE-1118 (improve logic of purge service)
>
> See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
>
>
> This addresses bug OOZIE-1118.
> https://issues.apache.org/jira/browse/OOZIE-1118
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1460860
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1460860
>
> Diff: https://reviews.apache.org/r/9942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Kanter
>
>
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
> On April 4, 2013, 12:07 a.m., Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java, line 300
> > <https://reviews.apache.org/r/9942/diff/9/?file=274750#file274750line300>
> >
> > same as purgeWF
Because coordinators can't have other Coords as children (i.e. no dependencies between them), we can actually delete them in any order; I only did it like this because I had to for WFs. So, I think you're right that it would be simpler to do this in a forward loop by chunks (though we don't need to do Collections.reverse() on it).
> On April 4, 2013, 12:07 a.m., Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java, line 313
> > <https://reviews.apache.org/r/9942/diff/9/?file=274750#file274750line313>
> >
> > same as purgeWF
> >
> >
Same as purgeCoordinators
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/#review18677
-----------------------------------------------------------
On March 27, 2013, 12:18 a.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9942/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 12:18 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Patch for OOZIE-1118 (improve logic of purge service)
>
> See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
>
>
> This addresses bug OOZIE-1118.
> https://issues.apache.org/jira/browse/OOZIE-1118
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1460860
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1460860
>
> Diff: https://reviews.apache.org/r/9942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Kanter
>
>
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/#review18677
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment39068>
if you do this, then nextIndex should be decremented as well.
It seems there are too many moving parts in here, nextIndex, i, wfs.size().
Couldn't we just use a temporary list where to add the WFs that qualify?
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment39069>
the order of params in the WorkflowJobsGetFromParentIdJPAExecutor constructor is counter-intuitive, it should first offset then len instead of len and offset.
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment39070>
similar to processWFs, having a temp list for whitelisted coord IDs may simplify the loop logic.
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment39071>
same as processWF and COORDs on the loop logic.
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment39072>
wouldn't be easier to Collections.reverse() the list and then do a forward loop by chunks ?
for (int i = 0; i < wf.size(); i += limit) {
delete(i*limit, (i+1)*limit);
}
delete((i-1)*limit, wf.size())
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment39073>
same as purgeWF
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/9942/#comment39074>
same as purgeWF
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java
<https://reviews.apache.org/r/9942/#comment39075>
offset, len it should be the order of params.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java
<https://reviews.apache.org/r/9942/#comment39076>
offset, len should be the order of params
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java
<https://reviews.apache.org/r/9942/#comment39077>
offset, len should be the order of params
- Alejandro Abdelnur
On March 27, 2013, 12:18 a.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9942/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 12:18 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Patch for OOZIE-1118 (improve logic of purge service)
>
> See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
>
>
> This addresses bug OOZIE-1118.
> https://issues.apache.org/jira/browse/OOZIE-1118
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1460860
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1460860
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1460860
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1460860
>
> Diff: https://reviews.apache.org/r/9942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Kanter
>
>
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 27, 2013, 12:18 a.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1460860
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1460860
trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1460860
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1460860
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1460860
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1460860
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1460860
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1460860
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 25, 2013, 7:55 p.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1460860
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1460860
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1460860
trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1460860
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1460860
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1460860
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1460860
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1460860
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1460860
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1460860
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 22, 2013, 12:49 a.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1459602
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459602
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1459602
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459602
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459602
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1459602
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1459602
trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1459602
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1459602
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java 1459602
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1459602
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1459602
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1459602
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1459602
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1459602
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1459602
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1459602
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1459602
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1459602
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1459602
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1459602
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1459602
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1459602
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 20, 2013, 12:06 a.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1458507
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1458507
trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1458507
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1458507
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1458507
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1458507
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1458507
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1458507
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1458507
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1458507
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1458507
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1458507
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1458507
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1458507
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1458507
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1458507
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 19, 2013, 9:05 p.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1458507
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1458507
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1458507
trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1458507
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1458507
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1458507
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1458507
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1458507
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1458507
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1458507
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1458507
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1458507
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1458507
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1458507
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1458507
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1458507
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1458507
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 18, 2013, 11:19 p.m.)
Review request for oozie.
Description (updated)
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1458056
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1458056
trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1458056
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1458056
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1458056
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1458056
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1458056
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1458056
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1458056
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1458056
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1458056
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1458056
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1458056
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1458056
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1458056
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1458056
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 18, 2013, 11:17 p.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
These files are deleted, but I didn't end up in the patch on RB for some reason:
- BulkDeleteForPurgeJPAExecutor.java
- TestBulkDeleteForPurgeJPAExecutor.java
- BundlePurgeXCommand.java
- CoordPurgeXCommand.java
- wf/PurgeXCommand.java
- TestBundlePurgeXCommand.java
- TestCoordPurgeXCommand.java
- wf/TestPurgeXCommand.java
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1458056
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java 1458056
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java 1458056
trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java 1458056
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java 1458056
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java 1458056
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java 1458056
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1458056
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1458056
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1458056
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1458056
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1458056
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java 1458056
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1458056
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1458056
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1458056
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1458056
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 15, 2013, 10:17 p.m.)
Review request for oozie.
Description (updated)
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
These files are deleted, but I didn't end up in the patch on RB for some reason:
- BulkDeleteForPurgeJPAExecutor.java
- TestBulkDeleteForPurgeJPAExecutor.java
- BundlePurgeXCommand.java
- CoordPurgeXCommand.java
- wf/PurgeXCommand.java
- TestBundlePurgeXCommand.java
- TestCoordPurgeXCommand.java
- wf/TestPurgeXCommand.java
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1456690
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1456690
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1456690
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1456690
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 15, 2013, 6 p.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1456690
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1456690
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1456690
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1456690
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1118 (improve logic of purge service)
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9942/
-----------------------------------------------------------
(Updated March 15, 2013, 5:37 p.m.)
Review request for oozie.
Description
-------
Patch for OOZIE-1118 (improve logic of purge service)
See https://issues.apache.org/jira/browse/OOZIE-1118 for more info
This addresses bug OOZIE-1118.
https://issues.apache.org/jira/browse/OOZIE-1118
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1456690
trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1456690
trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1456690
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1456690
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1456690
Diff: https://reviews.apache.org/r/9942/diff/
Testing
-------
Thanks,
Robert Kanter