[GitHub] jackjlli commented on a change in pull request #3684: Add touch method in PinotFS; Call touch when moving deleted segments.

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #3684: Add touch method in PinotFS; Call touch when moving deleted segments.
URL: https://github.com/apache/incubator-pinot/pull/3684#discussion_r247595037
 
 

 ##########
 File path: pinot-filesystem/src/main/java/org/apache/pinot/filesystem/PinotFS.java
 ##########
 @@ -137,13 +137,19 @@
 
   /**
    * Returns the age of the file
-   * @param uri
+   * @param uri location of file or directory
    * @return A long value representing the time the file was last modified, measured in milliseconds since epoch
    * (00:00:00 GMT, January 1, 1970) or 0L if the file does not exist or if an I/O error occurs
    * @throws Exception if uri is not valid or present
    */
   public abstract long lastModified(URI uri);
 
+  /**
+   * Creates a new empty file if it doesn't exist, or updates the last modified on existing file or directory.
 
 Review comment:
   According to the existing manual of touch command, the API throws an exception if the parent directory doesn't exist. We can follow this convention.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org