You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/29 20:07:18 UTC
[GitHub] [pulsar-helm-chart] frankjkelly opened a new pull request #181: [Istio] Kill istio proxy when container has completed
frankjkelly opened a new pull request #181:
URL: https://github.com/apache/pulsar-helm-chart/pull/181
### Motivation
When using Istio sidecars they keep running even when a Kubernetes job has completed.
For example
```
$ kubectl get pods | grep pulsar | grep init
platform-pulsar-bookkeeper-init-vwp6v 1/2 NotReady 0 13d
platform-pulsar-pulsar-init-c2c72 1/2 NotReady 0 13d
```
### Modifications
* Added a new Helm chart value `Istio.enabled` (default: false)
* In both Kubernetes jobs added a call to Istio to kill the Istio proxy once the container job has completed
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari merged pull request #181: Add ability to run extra commands in the initialization jobs e.g. to quit istio sidecars
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #181:
URL: https://github.com/apache/pulsar-helm-chart/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] frankjkelly commented on pull request #181: [Istio] Provide ability to kill istio proxy in sidecar when Init Job container has completed
Posted by GitBox <gi...@apache.org>.
frankjkelly commented on pull request #181:
URL: https://github.com/apache/pulsar-helm-chart/pull/181#issuecomment-1005168159
Helm chart 2.7.7 was already released. See
https://github.com/apache/pulsar-helm-chart/releases/tag/pulsar-2.7.7
and
https://pulsar.apache.org/charts/index.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie commented on a change in pull request #181: [Istio] Kill istio proxy when container has completed
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #181:
URL: https://github.com/apache/pulsar-helm-chart/pull/181#discussion_r768211745
##########
File path: charts/pulsar/templates/bookkeeper-cluster-initialize.yaml
##########
@@ -69,6 +69,9 @@ spec:
{{- end }}
bin/bookkeeper shell initnewcluster;
fi
+ {{- if .Values.istio.enabled }}
Review comment:
I would suggest a different approach:
Can you just introduce a setting called `extraInitCommand`? So you can include this in the init container. Then you can add this command to your values file. This provides better extensibility to the helm chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org