[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #3108: docs: add basic example for cpp binding

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #3108:
URL: https://github.com/apache/incubator-opendal/pull/3108#discussion_r1328256144


##########
examples/cpp/CMakeLists.txt:
##########
@@ -0,0 +1,20 @@
+cmake_minimum_required(VERSION 3.10)
+project(opendal-cpp-examples)
+
+set(CMAKE_CXX_STANDARD 17)
+
+include(FetchContent)
+FetchContent_Declare(
+    opendal-cpp
+    URL     https://github.com/apache/incubator-opendal/releases/download/v0.40.0/opendal-cpp-v0.40.0.tar.gz

Review Comment:
   How about point to a commit so that we can run it in CI.



##########
examples/cpp/CMakeLists.txt:
##########
@@ -0,0 +1,20 @@
+cmake_minimum_required(VERSION 3.10)
+project(opendal-cpp-examples)
+
+set(CMAKE_CXX_STANDARD 17)
+
+include(FetchContent)
+FetchContent_Declare(
+    opendal-cpp
+    URL     https://github.com/apache/incubator-opendal/releases/download/v0.40.0/opendal-cpp-v0.40.0.tar.gz

Review Comment:
   How about point to a commit first so that we can run it in CI?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org