[GitHub] [spark] HyukjinKwon commented on a change in pull request #24268: [SPARK-26856][PYSPARK][FOLLOWUP] Fix UT failure due to wrong patterns for Kinesis assembly

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #24268: [SPARK-26856][PYSPARK][FOLLOWUP] Fix UT failure due to wrong patterns for Kinesis assembly
URL: https://github.com/apache/spark/pull/24268#discussion_r271132222
 
 

 ##########
 File path: python/pyspark/testing/utils.py
 ##########
 @@ -103,7 +103,7 @@ def close(self):
         pass
 
 
-def search_jar(project_relative_path, jar_name_prefix):
+def search_jar(project_relative_path, sbt_jar_name_prefix, mvn_jar_name_prefix):
 
 Review comment:
   Yes, I can't think of another minimised fix. It's a testing util anyway. we can fix it later if we can come up with a better idea. LGTM.
   
   While we're here, mind adding some comments? It doesn't need to be a proper docstring. We can just write something like:
   
   ```python
   def search_jar(project_relative_path, sbt_jar_name_prefix, mvn_jar_name_prefix):
       # Note that 'sbt_jar_name_prefix' and 'mvn_jar_name_prefix' are separate since the prefix can
       # be varied for SBT or Maven specifically. See also SPARK-26856
       ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org