You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/09 17:12:38 UTC
[GitHub] [rocketmq] gogodjzhu opened a new pull request, #4141: Fix spelling problem on docs/en
gogodjzhu opened a new pull request, #4141:
URL: https://github.com/apache/rocketmq/pull/4141
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Fix some spelling problem on docs.
## Brief changelog
Almost all docs on `docs/en` directory.
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#issuecomment-1094675941
[](https://coveralls.io/builds/48159164)
Coverage decreased (-0.08%) to 51.884% when pulling **6a19470548260768a3a1e6618bd031f912e3d8b5 on gogodjzhu:fix-spelling-patch** into **ead6274b3e8016ee2fa75cf0dc201b5581ee7a34 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on a diff in pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
vongosling commented on code in PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#discussion_r846889501
##########
docs/en/Example_OpenMessaging.md:
##########
@@ -1,5 +1,5 @@
# OpenMessaging Example
-[OpenMessaging](https://openmessaging.github.io/), which includes the establishment of industry guidelines and messaging, streaming specifications to provide a common framework for finance, ecommerce, IoT and big-data area. The design principles are the cloud-oriented, simplicity, flexibility, and language independent in distributed heterogeneous environments. Conformance to these specifications will make it possible to develop a heterogeneous messaging applications across all major platforms and operating systems.
+[OpenMessaging](https://openmessaging.github.io/), which includes the establishment of industry guidelines and messaging, streaming specifications to provide a common framework for finance, commerce, IoT and big-data area. The design principles are the cloud-oriented, simplicity, flexibility, and language independent in distributed heterogeneous environments. Conformance to these specifications will make it possible to develop a heterogeneous messaging applications across all major platforms and operating systems.
Review Comment:
e-commerce would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 commented on a diff in pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
yuz10 commented on code in PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#discussion_r846991124
##########
docs/en/Troubleshoopting.md:
##########
@@ -73,4 +73,4 @@ SendResult [sendStatus=SEND_OK, msgId=0A42333A0DC818B4AAC246C290FD0000, offsetMs
```
- msgId，for the client, the msgId is generated by the producer instance. Specifically, the method `MessageClientIDSetter.createUniqIDBuffer()` is called to generate a unique Id.
-- offsetMsgId, offsetMsgId is generated by the Broker server when writing a message ( string concating "IP address + port" and "CommitLog's physical offset address"), and offsetMsgId is the messageId used to query in the RocketMQ console.
+- offsetMsgId, offsetMsgId is generated by the Broker server when writing a message ( string concat with "IP address + port" and "CommitLog's physical offset address"), and offsetMsgId is the messageId used to query in the RocketMQ console.
Review Comment:
IMO, better use ` string consisting of "IP address + port" and "CommitLog's physical offset address"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] gogodjzhu commented on pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
gogodjzhu commented on PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#issuecomment-1094642446
Fresher in the town :) Thanks for the suggestions and changes has been commited. @dugenkui03 @vongosling @yuz10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] gogodjzhu closed pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
gogodjzhu closed pull request #4141: Fix spelling problem on docs/en
URL: https://github.com/apache/rocketmq/pull/4141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] gogodjzhu commented on pull request #4141: [ISSUE #4150] Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
gogodjzhu commented on PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#issuecomment-1095005719
this pr is related to #4141
@vongosling Next time will be issue first and pr follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#issuecomment-1094675932
[](https://coveralls.io/builds/48159164)
Coverage decreased (-0.08%) to 51.884% when pulling **6a19470548260768a3a1e6618bd031f912e3d8b5 on gogodjzhu:fix-spelling-patch** into **ead6274b3e8016ee2fa75cf0dc201b5581ee7a34 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
vongosling commented on PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#issuecomment-1094458602
@gogodjzhu @dugenkui03 very much appreciate your careful revision :-) I hope to see more of you in the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 merged pull request #4141: [ISSUE #4150] Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
yuz10 merged PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] dugenkui03 commented on pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
dugenkui03 commented on PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#issuecomment-1094157287
提交包括其他人commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] gogodjzhu commented on pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
gogodjzhu commented on PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#issuecomment-1094637953
> 提交包括其他人commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on pull request #4141: Fix spelling problem on docs/en
Posted by GitBox <gi...@apache.org>.
vongosling commented on PR #4141:
URL: https://github.com/apache/rocketmq/pull/4141#issuecomment-1094710547
The last step. It would be helpful to create a related issue and associate with it, just like others do. It is also our basic community requirements :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org