You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/08/16 05:47:54 UTC
[GitHub] [hop] weiqingping opened a new pull request, #1635: [HOP-Coalesce] - Fixes bug in SessionManager`
weiqingping opened a new pull request, #1635:
URL: https://github.com/apache/hop/pull/1635
I found that the result always takes the first column regardless of whether the first column is null or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216373091
Confirmed, so the problem actually is the binary-string types.
Thank you @weiqingping !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216415115
Just wanted to add that this breaks every other case except binary-string, but you noticed it too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] weiqingping commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
weiqingping commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216354012
the data's input is cvs. but the log show that the target field is null
<img width="543" alt="result" src="https://user-images.githubusercontent.com/12055463/184842404-c469f74f-c9bf-49af-b4c0-f4ee40aa7193.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] weiqingping commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
weiqingping commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216438095
> @weiqingping,
>
> You will have to revert the Mysql change though, the IValueMeta.TYPE_DATE is a Java Date and contains date + Time. This then translates to a DateTime in Mysql.
>
> The difference between IValueMeta.TYPE_DATE and IValueMeta.TYPE_TIMESTAMP is the objects behind it Java Date vs Java Time
the problem is that the db's field type is Date but it show DateTime in the hop's ui.
<img width="604" alt="1660644458373" src="https://user-images.githubusercontent.com/12055463/184855148-db0c9e0e-0833-42bd-8759-876eee0bbd48.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] weiqingping commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
weiqingping commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216418456
> Confirmed, so the problem actually is the binary-string types. Thank you @weiqingping !
I get it. I modified it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] weiqingping commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
weiqingping commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216356009
<img width="399" alt="data" src="https://user-images.githubusercontent.com/12055463/184842623-71d50500-11af-411b-9867-4f15ead4ae9f.png">
<img width="571" alt="first" src="https://user-images.githubusercontent.com/12055463/184842668-b0869bc0-0b61-4172-8f3d-67b2b936f2cf.png">
<img width="571" alt="second" src="https://user-images.githubusercontent.com/12055463/184842759-370df642-4c99-4116-b0eb-23e3eff1661d.png">
<img width="240" alt="thrid" src="https://user-images.githubusercontent.com/12055463/184842797-365cbe04-0f58-4e03-b0ac-13b639643225.png">
<img width="455" alt="transform-flow" src="https://user-images.githubusercontent.com/12055463/184842840-956eb2b6-d1f1-4863-83d5-2f267575412d.png">
<img width="543" alt="result" src="https://user-images.githubusercontent.com/12055463/184842873-bd714f8b-7f78-49a1-9b72-8939107435bf.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216424156
@weiqingping,
You will have to revert the Mysql change though, the IValueMeta.TYPE_DATE is a Java Date and contains date + Time.
This then translates to a DateTime in Mysql.
The difference between IValueMeta.TYPE_DATE and IValueMeta.TYPE_TIMESTAMP is the objects behind it
Java Date vs Java Time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216458510
The generated DDL does not show the actual DDL of the table, it shows how we would create the table.
And because we have no date-only type we suggest DateTime indeed.
A Hop "Date" is DateTime and if we select a MySQL Date from a table we have to convert it to a Hop Date and will contain time again (00:00:00 timestamp in the backend). I know it's a bit annoying but we will have more errors if we suggest the Date type because people will wonder where their time has gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1216319413
Can you give a sample of what this should fix?
We have a test on this and as far as I can see the result is correct.
<img width="1017" alt="image" src="https://user-images.githubusercontent.com/1140235/184835857-39f34530-cadc-4aeb-952f-64ce13caa90a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] weiqingping commented on pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
weiqingping commented on PR #1635:
URL: https://github.com/apache/hop/pull/1635#issuecomment-1217344022
> The generated DDL does not show the actual DDL of the table, it shows how we would create the table. And because we have no date-only type we suggest DateTime indeed.
>
> A Hop "Date" is DateTime and if we select a MySQL Date from a table we have to convert it to a Hop Date and will contain time again (00:00:00 timestamp in the backend). I know it's a bit annoying but we will have more errors if we suggest the Date type because people will wonder where their time has gone.
>
> Edit: But I would honestly never suggest creating tables from the UI, your DDL should be managed outside of Hop
OK ,I understand. thank you @hansva
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1635: [HOP-Coalesce] - Fixes bug in Coalesce plugin
Posted by GitBox <gi...@apache.org>.
hansva merged PR #1635:
URL: https://github.com/apache/hop/pull/1635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org