[GitHub] kppullin commented on a change in pull request #4319: [AIRFLOW-2770] Read `dags_in_image` config value as a boolean

[GitBox <gi...@apache.org>]

kppullin commented on a change in pull request #4319: [AIRFLOW-2770] Read `dags_in_image` config value as a boolean
URL: https://github.com/apache/incubator-airflow/pull/4319#discussion_r241518434
 
 

 ##########
 File path: airflow/contrib/executors/kubernetes_executor.py
 ##########
 @@ -139,7 +139,7 @@ def __init__(self):
 
         # NOTE: user can build the dags into the docker image directly,
         # this will set to True if so
-        self.dags_in_image = conf.get(self.kubernetes_section, 'dags_in_image')
+        self.dags_in_image = conf.getboolean(self.kubernetes_section, 'dags_in_image')
 
 Review comment:
   This _might_ be considered a breaking change.  It appears that `getboolean` throws an exception if the value is empty, so if someone does not update their config file to include `dags_in_image` their setup will break.
   
   Looking for suggestions on how best to work around this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services