You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/06/05 06:31:42 UTC
[PR] Fix PBTree schema cache release after pre-delete (#17834) [iotdb]
Caideyipi opened a new pull request, #17852:
URL: https://github.com/apache/iotdb/pull/17852
## Description
Backport d182c87a4013d83933f4937a3d174c736b1d783c to dev/1.3.
This fixes PBTree schema cache release after pre-delete by releasing skipped pre-deleted measurement nodes during traversal and making forceFlushAndRelease wait for worker tasks before checking/releasing cached nodes.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
- ReleaseFlushMonitor
- Traverser
- SchemaStatisticsTest
##### Tests
- PASS: mvn -DskipTests spotless:check -pl iotdb-core/datanode
- FAIL: mvn -pl iotdb-core/datanode -Dtest=SchemaStatisticsTest test (compilation failed while reading many unrelated Java source files, for example SchemaQueryScanNode.java and MergeSortKey.java; the cherry-picked files were not reported as compile errors)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PBTree schema cache release after pre-delete (#17834) [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #17852:
URL: https://github.com/apache/iotdb/pull/17852#issuecomment-4629161410
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/17852?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.00000%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 42.57%. Comparing base ([`b885269`](https://app.codecov.io/gh/apache/iotdb/commit/b8852699a495458169e7078a5554d92275e06545?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2d844de`](https://app.codecov.io/gh/apache/iotdb/commit/2d844de0adc1b1e9f6777ef78aa3171250655118?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on dev/1.3.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/17852?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../mtree/impl/pbtree/memory/ReleaseFlushMonitor.java](https://app.codecov.io/gh/apache/iotdb/pull/17852?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fschemaengine%2Fschemaregion%2Fmtree%2Fimpl%2Fpbtree%2Fmemory%2FReleaseFlushMonitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc2NoZW1hZW5naW5lL3NjaGVtYXJlZ2lvbi9tdHJlZS9pbXBsL3BidHJlZS9tZW1vcnkvUmVsZWFzZUZsdXNoTW9uaXRvci5qYXZh) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev/1.3 #17852 +/- ##
==========================================
Coverage 42.56% 42.57%
Complexity 241 241
==========================================
Files 3621 3621
Lines 240247 240260 +13
Branches 29263 29263
==========================================
+ Hits 102257 102286 +29
+ Misses 137990 137974 -16
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/17852?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PBTree schema cache release after pre-delete (#17834) [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #17852:
URL: https://github.com/apache/iotdb/pull/17852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PBTree schema cache release after pre-delete (#17834) [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17852:
URL: https://github.com/apache/iotdb/pull/17852#issuecomment-4628885742
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17852) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17852&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17852&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17852&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17852&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17852&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17852)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org