You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/10/26 22:57:17 UTC
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11804
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
---
M docs/impala.ditamap
A docs/topics/impala_max_mem_estimate_for_admission.xml
2 files changed, 93 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11804/1
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Reviewed-on: http://gerrit.cloudera.org:8080/11804
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/impala.ditamap
A docs/topics/impala_max_mem_estimate_for_admission.xml
2 files changed, 90 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11804/1/docs/topics/impala_max_mem_estimate_for_admission.xml
File docs/topics/impala_max_mem_estimate_for_admission.xml:
http://gerrit.cloudera.org:8080/#/c/11804/1/docs/topics/impala_max_mem_estimate_for_admission.xml@58
PS1, Line 58: <li>
: The <codeph>--mem_limit</codeph> startup option is not set.
: </li>
this condition is not required.
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 23:09:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:52:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Looks good. Just another small nit
http://gerrit.cloudera.org:8080/#/c/11804/2/docs/topics/impala_max_mem_estimate_for_admission.xml
File docs/topics/impala_max_mem_estimate_for_admission.xml:
http://gerrit.cloudera.org:8080/#/c/11804/2/docs/topics/impala_max_mem_estimate_for_admission.xml@45
PS2, Line 45: on the memory estimates of a query
on the planner's memory estimates for a query
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 17:29:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/119/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 23:08:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11804
to look at the new patch set (#2).
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
---
M docs/impala.ditamap
A docs/topics/impala_max_mem_estimate_for_admission.xml
2 files changed, 89 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11804/2
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/120/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 23:14:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11804
to look at the new patch set (#3).
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
---
M docs/impala.ditamap
A docs/topics/impala_max_mem_estimate_for_admission.xml
2 files changed, 90 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11804/3
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 3:
One clarification per Tim's comment on the MEM_LIMIT option requirement.
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 21:30:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/119/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 22:57:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/124/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 21:29:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/120/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 23:27:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11804/1/docs/topics/impala_max_mem_estimate_for_admission.xml
File docs/topics/impala_max_mem_estimate_for_admission.xml:
http://gerrit.cloudera.org:8080/#/c/11804/1/docs/topics/impala_max_mem_estimate_for_admission.xml@58
PS1, Line 58: <li>
: The <codeph>--mem_limit</codeph> startup option is not set.
: </li>
> this condition is not required.
Removed
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 23:15:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 )
Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/124/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef89c98530c6974dc791666cc51c1ded52e7910
Gerrit-Change-Number: 11804
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 21:31:53 +0000
Gerrit-HasComments: No