You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by amaya382 <gi...@git.apache.org> on 2017/05/17 04:29:18 UTC

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

GitHub user amaya382 opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/80

    [WIP][HIVEMALL-99] Cross-compilation of XGBoost using Docker

    ## What changes were proposed in this pull request?
    
    Cross compiling xgboost using dockcross
    
    ## What type of PR is it?
    
    Improvement
    
    ## What is the Jira issue?
    
    [[HIVEMALL-99]](https://issues.apache.org/jira/browse/HIVEMALL-99)
    
    ## How was this patch tested?
    
    (Need to decide)
    
    ## How to use this feature?
    
    ```sh
    # make xgboost-${arch}
    make xgboost-linux-x64
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amaya382/incubator-hivemall cross-compiling

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #80
    
----
commit b7d162de9f0f1bf97e4d17d0266f939e0d96134f
Author: amaya <ma...@sapphire.in.net>
Date:   2017-05-17T02:38:55Z

    WIP

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @maropu This isn't directly related with this PR, but I faced the following errors. Do you have any ideas? It seems that labels aren't set properly.
    
    Env: Docker, xgboost native built on local
    
    Commands in hive
    ```sql
    add jar /opt/hivemall/target/hivemall-core-0.4.2-rc.2-with-dependencies.jar;
    source /opt/hivemall/resources/ddl/define-all.hive;
    add jar /opt/hivemall/target/hivemall-xgboost-0.60-0.4.2-rc.2-with-dependencies.jar;
    source /opt/hivemall/resources/ddl/define-additional.hive;
    
    set hivevar:f0_min=4.3;
    set hivevar:f0_max=7.9;
    set hivevar:f1_min=2.0;
    set hivevar:f1_max=4.4;
    set hivevar:f2_min=1.0;
    set hivevar:f2_max=6.9;
    set hivevar:f3_min=0.1;
    set hivevar:f3_max=2.5;
    
    use iris;
    create or replace view iris_scaled
    as
    select
      rowid, 
      label,
      add_bias(array(
         concat("1:", rescale(features[0],${hivevar:f0_min},${hivevar:f0_max})), 
         concat("2:", rescale(features[1],${hivevar:f1_min},${hivevar:f1_max})), 
         concat("3:", rescale(features[2],${hivevar:f2_min},${hivevar:f2_max})), 
         concat("4:", rescale(features[3],${hivevar:f3_min},${hivevar:f3_max}))
      )) as features
    from 
      iris_raw;
    
    -- select * from iris_scaled limit 3;
    -- 1       Iris-setosa     ["1:0.22222215","2:0.625","3:0.0677966","4:0.041666664","0:1.0"]
    -- 2       Iris-setosa     ["1:0.16666664","2:0.41666666","3:0.0677966","4:0.041666664","0:1.0"]
    -- 3       Iris-setosa     ["1:0.11111101","2:0.5","3:0.05084745","4:0.041666664","0:1.0"]
    
    select train_xgboost_classifier(features, case when label = 'Iris-setosa' then 1.0 else 0.0 end) from iris_scaled; -- got exception
    ```
    
    ```
    Failed with exception java.io.IOException:java.lang.ClassCastException: org.apache.hadoop.io.Text cannot be cast to java.lang.String
    [20:51:33] dmlc-core/include/dmlc/logging.h:235: [20:51:33] src/objective/regression_obj.cc:89: Check failed: (info.labels.size()) != (0) label set cannot be empty
    org.apache.hadoop.hive.ql.metadata.HiveException: [20:51:33] src/objective/regression_obj.cc:89: Check failed: (info.labels.size()) != (0) label set cannot be empty
    Check failed: (info.labels.size()) != (0) label set cannot be empty
            at hivemall.xgboost.XGBoostUDTF.close(XGBoostUDTF.java:313)
            at org.apache.hadoop.hive.ql.exec.UDTFOperator.closeOp(UDTFOperator.java:152)
            at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:683)
            at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:697)
            at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:697)
            at org.apache.hadoop.hive.ql.exec.FetchOperator.closeOperator(FetchOperator.java:552)
            at org.apache.hadoop.hive.ql.exec.FetchOperator.clearFetchContext(FetchOperator.java:535)
            at org.apache.hadoop.hive.ql.exec.FetchTask.clearFetch(FetchTask.java:191)
            at org.apache.hadoop.hive.ql.Driver.releaseFetchTask(Driver.java:2233)
            at org.apache.hadoop.hive.ql.Driver.close(Driver.java:2278)
            at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:269)
            at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:183)
            at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:399)
            at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:776)
            at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:714)
            at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:641)
            at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
            at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            at java.lang.reflect.Method.invoke(Method.java:606)
            at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
            at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
    org.apache.hadoop.hive.ql.metadata.HiveException: [20:51:33] src/objective/regression_obj.cc:89: Check failed: (info.labels.size()) != (0) label set cannot be empty
            at hivemall.xgboost.XGBoostUDTF.close(XGBoostUDTF.java:313)
            at org.apache.hadoop.hive.ql.exec.UDTFOperator.closeOp(UDTFOperator.java:152)
            at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:683)
            at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:697)
            at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:697)
            at org.apache.hadoop.hive.ql.exec.FetchOperator.closeOperator(FetchOperator.java:552)
            at org.apache.hadoop.hive.ql.exec.FetchOperator.clearFetchContext(FetchOperator.java:535)
            at org.apache.hadoop.hive.ql.exec.FetchTask.clearFetch(FetchTask.java:191)
            at org.apache.hadoop.hive.ql.Driver.releaseFetchTask(Driver.java:2233)
            at org.apache.hadoop.hive.ql.Driver.close(Driver.java:2278)
            at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:269)
            at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:183)
            at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:399)
            at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:776)
            at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:714)
            at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:641)
            at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
            at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            at java.lang.reflect.Method.invoke(Method.java:606)
            at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
            at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
    Time taken: 3.375 seconds
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @myui It has been tested only on local, plz wait a little


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @myui okay. what should I set default arch in [here](https://github.com/apache/incubator-hivemall/pull/80/files#diff-600376dffeb79835ede4a0b285078036) or provide multiple binaries?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @maropu you can use Docker.
    
    ```
    docker pull hivemall/latest:20170517
    docker run -p 8088:8088 -p 50070:50070 -p 19888:19888 -it hivemall/latest:20170517
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r117665318
  
    --- Diff: xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java ---
    @@ -54,15 +55,47 @@ private static boolean hasResource(String path) {
         }
     
         private static String getOSName() {
    -        return System.getProperty("os.name");
    +        return System.getProperty("os.name").toLowerCase();
    +    }
    +
    +    private static String getOSArch() {
    +        return System.getProperty("os.arch").toLowerCase();
    +    }
    +
    +    private static String getOSArchString() {
    +        String os = getOSName();
    +        if(os.startsWith("linux")) {
    +            os = "linux";
    +        } else if(os.startsWith("mac")) {
    +            os = "darwin";
    +        } else if(os.startsWith("windows")) {
    +            os = "windows";
    +        }
    +
    +        String arch = getOSArch();
    +        if(arch.equals("amd64") || arch.equals("x86_64")) {
    +            arch = "x64";
    +        } else if(arch.endsWith("86")) {
    +            arch = "x86";
    +        } else if(arch.indexOf("arm64") != -1) {
    +            arch = "arm64";
    +        } else if(arch.indexOf("armv6") != -1) {
    +            arch = "armv6";
    +        } else if(arch.indexOf("armv7") != -1) {
    +            arch = "armv7";
    +        } else if(arch.indexOf("ppc") != -1) {
    +            arch = "ppc64le";
    +        }
    +
    +        return os + "-" + arch;
    --- End diff --
    
    that's so, I'll mod it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @myui @maropu 
    * How to distribute each product?
    * How to test them on CI?
    
    Other topic
    Would you like to move build scripts into Makefile?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r117665985
  
    --- Diff: bin/build_xgboost.sh ---
    @@ -1,87 +0,0 @@
    -#!/bin/bash
    -#
    -# Licensed to the Apache Software Foundation (ASF) under one
    -# or more contributor license agreements.  See the NOTICE file
    -# distributed with this work for additional information
    -# regarding copyright ownership.  The ASF licenses this file
    -# to you under the Apache License, Version 2.0 (the
    -# "License"); you may not use this file except in compliance
    -# with the License.  You may obtain a copy of the License at
    -#
    -#   http://www.apache.org/licenses/LICENSE-2.0
    -#
    -# Unless required by applicable law or agreed to in writing,
    -# software distributed under the License is distributed on an
    -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    -# KIND, either express or implied.  See the License for the
    -# specific language governing permissions and limitations
    -# under the License.
    -#
    -
    -# xgboost requires g++-4.6 or higher (https://github.com/dmlc/xgboost/blob/master/doc/build.md),
    -# so we need to first check if the requirement is satisfied.
    -COMPILER_REQUIRED_VERSION="4.6"
    -COMPILER_VERSION=`g++ --version 2> /dev/null`
    -
    -# Check if GNU g++ installed
    -if [ $? = 127 ]; then
    --- End diff --
    
    @maropu no need to support `clang` anymore. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 Thanks! Coverage/covealls decrease is acceptable for this PR. Is it still WIP?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r117657316
  
    --- Diff: xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java ---
    @@ -54,15 +55,47 @@ private static boolean hasResource(String path) {
         }
     
         private static String getOSName() {
    -        return System.getProperty("os.name");
    +        return System.getProperty("os.name").toLowerCase();
    +    }
    +
    +    private static String getOSArch() {
    +        return System.getProperty("os.arch").toLowerCase();
    +    }
    +
    +    private static String getOSArchString() {
    +        String os = getOSName();
    +        if(os.startsWith("linux")) {
    +            os = "linux";
    +        } else if(os.startsWith("mac")) {
    +            os = "darwin";
    +        } else if(os.startsWith("windows")) {
    +            os = "windows";
    +        }
    +
    +        String arch = getOSArch();
    +        if(arch.equals("amd64") || arch.equals("x86_64")) {
    +            arch = "x64";
    +        } else if(arch.endsWith("86")) {
    +            arch = "x86";
    +        } else if(arch.indexOf("arm64") != -1) {
    +            arch = "arm64";
    +        } else if(arch.indexOf("armv6") != -1) {
    +            arch = "armv6";
    +        } else if(arch.indexOf("armv7") != -1) {
    +            arch = "armv7";
    +        } else if(arch.indexOf("ppc") != -1) {
    +            arch = "ppc64le";
    +        }
    +
    +        return os + "-" + arch;
    --- End diff --
    
    I think you could refer [the code](https://github.com/xerial/snappy-java/blob/master/src/main/java/org/xerial/snappy/OSInfo.java) in `snappy-java` to handle almost all the case for detecting arch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @myui thanks for reporting bugs, fixed first bug. it seems second bug is problem related to first bug or particular to macOS. plz fetch the latest and retry. if former, will be resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 Instead of using dockcross, I built native xgboost binaries for most Linux platform and Mac OSX in https://github.com/myui/build-xgboost-jvm/ 
    
    To support more platforms, this PR is useful but we can close this PR for now. Thank you for your work but do you mind closing/archiving this PR for the time being?


---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 Sorry to be late. https://github.com/apache/incubator-hivemall/pull/95 is now merged. So, please rebase and test again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @maropu by qemu? or do you have any ideas?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r117657090
  
    --- Diff: bin/build_xgboost.sh ---
    @@ -1,87 +0,0 @@
    -#!/bin/bash
    -#
    -# Licensed to the Apache Software Foundation (ASF) under one
    -# or more contributor license agreements.  See the NOTICE file
    -# distributed with this work for additional information
    -# regarding copyright ownership.  The ASF licenses this file
    -# to you under the Apache License, Version 2.0 (the
    -# "License"); you may not use this file except in compliance
    -# with the License.  You may obtain a copy of the License at
    -#
    -#   http://www.apache.org/licenses/LICENSE-2.0
    -#
    -# Unless required by applicable law or agreed to in writing,
    -# software distributed under the License is distributed on an
    -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    -# KIND, either express or implied.  See the License for the
    -# specific language governing permissions and limitations
    -# under the License.
    -#
    -
    -# xgboost requires g++-4.6 or higher (https://github.com/dmlc/xgboost/blob/master/doc/build.md),
    -# so we need to first check if the requirement is satisfied.
    -COMPILER_REQUIRED_VERSION="4.6"
    -COMPILER_VERSION=`g++ --version 2> /dev/null`
    -
    -# Check if GNU g++ installed
    -if [ $? = 127 ]; then
    --- End diff --
    
    @amaya382 Does the new script works for both gcc and clang?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @maropu Created https://issues.apache.org/jira/projects/HIVEMALL/issues/HIVEMALL-119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 Could you file a jira for that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    
    [![Coverage Status](https://coveralls.io/builds/12706099/badge)](https://coveralls.io/builds/12706099)
    
    Coverage increased (+0.2%) to 40.984% when pulling **220e4cf6205fbe39f15cd0741755854a0b29864c on amaya382:cross-compiling** into **7ec82a6a87dc7fd6d0b8cd08fc2bb640f36f6315 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    We need to have these binaries for older linux platforms? I think xgboost actually does not work on those older ones. Also, we need to compile xgboost for some platforms (e.g., arm and some bigendian ones). That is because Spark does not work well on those platforms: See: https://issues.apache.org/jira/browse/SPARK-13736. I'm not sure though, Hive works on those?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    `$ JAVA_HOME=`/usr/libexec/java_home -v 1.8` make xgboost-native-local`
    `javac: ディレクトリがありません: xgboost/target/classes`
    
    Need to run `mkdir -p xgboost/target/classes` first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    
    [![Coverage Status](https://coveralls.io/builds/11558895/badge)](https://coveralls.io/builds/11558895)
    
    Coverage remained the same at 38.694% when pulling **b7d162de9f0f1bf97e4d17d0266f939e0d96134f on amaya382:cross-compiling** into **68f6b465248117d085a9cdb7b532837b14e054c5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r117665868
  
    --- Diff: bin/build_xgboost.sh ---
    @@ -1,87 +0,0 @@
    -#!/bin/bash
    -#
    -# Licensed to the Apache Software Foundation (ASF) under one
    -# or more contributor license agreements.  See the NOTICE file
    -# distributed with this work for additional information
    -# regarding copyright ownership.  The ASF licenses this file
    -# to you under the Apache License, Version 2.0 (the
    -# "License"); you may not use this file except in compliance
    -# with the License.  You may obtain a copy of the License at
    -#
    -#   http://www.apache.org/licenses/LICENSE-2.0
    -#
    -# Unless required by applicable law or agreed to in writing,
    -# software distributed under the License is distributed on an
    -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    -# KIND, either express or implied.  See the License for the
    -# specific language governing permissions and limitations
    -# under the License.
    -#
    -
    -# xgboost requires g++-4.6 or higher (https://github.com/dmlc/xgboost/blob/master/doc/build.md),
    -# so we need to first check if the requirement is satisfied.
    -COMPILER_REQUIRED_VERSION="4.6"
    -COMPILER_VERSION=`g++ --version 2> /dev/null`
    -
    -# Check if GNU g++ installed
    -if [ $? = 127 ]; then
    --- End diff --
    
    We'd be better off printing explicit error messages when `clang` used. Could you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 closed the pull request at:

    https://github.com/apache/incubator-hivemall/pull/80


---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    `git fetch; git rebase master` is required to resolve this conflict.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    
    [![Coverage Status](https://coveralls.io/builds/12414313/badge)](https://coveralls.io/builds/12414313)
    
    Coverage decreased (-0.2%) to 40.596% when pulling **be28fd469969cccba63f65a444a0d267f0faca95 on amaya382:cross-compiling** into **7ec82a6a87dc7fd6d0b8cd08fc2bb640f36f6315 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 Fist of all, thank you for the contribution!
    
    Could you share the result of `ldd libxgboost4j.so` ?
    
    We would like to create a `libxgboost4j.so` that runs on many linux system by using `-fPIC` option and static linking. 
    https://github.com/xerial/snappy-java/blob/master/BUILD.md#building-linux-x86_64-binary
    https://github.com/xerial/snappy-java/blob/master/Makefile#L169


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    yea, I think so. I just mean I can't reproduce in my laptop and I can't look into this issue...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    Yea, I also think we need to use `qemu` to test them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @myui 
    now
    ```
    linux-vdso.so.1 (0x00007ffdfc7cc000)
    librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fce0f7f6000)
    libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fce0f4f5000)
    libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fce0f2d7000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fce0ef2c000)
    /lib64/ld-linux-x86-64.so.2 (0x0000555866c1f000)
    ```
    
    `libgcc` and `libstdc++` are statically linked with `fPIC`. but still `libc` is dynamic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @myui 
    Ahh, I've got it! will fix it (currently not static-linked).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    
    [![Coverage Status](https://coveralls.io/builds/11619215/badge)](https://coveralls.io/builds/11619215)
    
    Coverage decreased (-0.04%) to 38.657% when pulling **d1e7ca427754ee0db6e4ea2393727bc83970ad05 on amaya382:cross-compiling** into **10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @myui Sorry for the work late, is this PR no longer necessary or not?


---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r117666401
  
    --- Diff: bin/build_xgboost.sh ---
    @@ -1,87 +0,0 @@
    -#!/bin/bash
    -#
    -# Licensed to the Apache Software Foundation (ASF) under one
    -# or more contributor license agreements.  See the NOTICE file
    -# distributed with this work for additional information
    -# regarding copyright ownership.  The ASF licenses this file
    -# to you under the Apache License, Version 2.0 (the
    -# "License"); you may not use this file except in compliance
    -# with the License.  You may obtain a copy of the License at
    -#
    -#   http://www.apache.org/licenses/LICENSE-2.0
    -#
    -# Unless required by applicable law or agreed to in writing,
    -# software distributed under the License is distributed on an
    -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    -# KIND, either express or implied.  See the License for the
    -# specific language governing permissions and limitations
    -# under the License.
    -#
    -
    -# xgboost requires g++-4.6 or higher (https://github.com/dmlc/xgboost/blob/master/doc/build.md),
    -# so we need to first check if the requirement is satisfied.
    -COMPILER_REQUIRED_VERSION="4.6"
    -COMPILER_VERSION=`g++ --version 2> /dev/null`
    -
    -# Check if GNU g++ installed
    -if [ $? = 127 ]; then
    --- End diff --
    
    this script uses `gcc` automatically on dockcross, never call `clang`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r117665209
  
    --- Diff: bin/build_xgboost.sh ---
    @@ -1,87 +0,0 @@
    -#!/bin/bash
    -#
    -# Licensed to the Apache Software Foundation (ASF) under one
    -# or more contributor license agreements.  See the NOTICE file
    -# distributed with this work for additional information
    -# regarding copyright ownership.  The ASF licenses this file
    -# to you under the Apache License, Version 2.0 (the
    -# "License"); you may not use this file except in compliance
    -# with the License.  You may obtain a copy of the License at
    -#
    -#   http://www.apache.org/licenses/LICENSE-2.0
    -#
    -# Unless required by applicable law or agreed to in writing,
    -# software distributed under the License is distributed on an
    -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    -# KIND, either express or implied.  See the License for the
    -# specific language governing permissions and limitations
    -# under the License.
    -#
    -
    -# xgboost requires g++-4.6 or higher (https://github.com/dmlc/xgboost/blob/master/doc/build.md),
    -# so we need to first check if the requirement is satisfied.
    -COMPILER_REQUIRED_VERSION="4.6"
    -COMPILER_VERSION=`g++ --version 2> /dev/null`
    -
    -# Check if GNU g++ installed
    -if [ $? = 127 ]; then
    --- End diff --
    
    @maropu No, building xgboost depends on gcc. because dockcross includes gcc, skips to check compiler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    
    [![Coverage Status](https://coveralls.io/builds/11746393/badge)](https://coveralls.io/builds/11746393)
    
    Coverage increased (+0.2%) to 38.872% when pulling **2883c30a2db706ab825f2c950d551c38f3cf9efa on amaya382:cross-compiling** into **10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @maropu I'll investigate it too, but want you to check it because i don't know xgboost in detail.
    In addition to myui's comment, increased my environment info into previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    
    [![Coverage Status](https://:/builds/11988303/badge)](https://:/builds/11988303)
    
    Coverage decreased (-0.1%) to 39.856% when pulling **139d33512c1a0e06f8c27e656edf5dfffb72e473 on amaya382:cross-compiling** into **02885f89fe8ef3545d4c150722ae9639754468f3 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    
    [![Coverage Status](https://:/builds/11961500/badge)](https://:/builds/11961500)
    
    Coverage increased (+0.3%) to 39.37% when pulling **013c23ba1b0f7f351a153feadffb37972d4deede on amaya382:cross-compiling** into **1dac1a62fbf35848deca8f0a8aa96f01dc1c0f2d on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 having dependencies to `libc` and `libm` is acceptable.
    https://github.com/xerial/snappy-java/issues/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    I would like to update xgboost version to latest using their official repository.
    
    @maropu I think it's better to use jitpack for jvm-packages of xgboost if maven repository is required.
    
    https://github.com/jitpack/maven-simple 
    https://github.com/myui/digdag-plugin-example/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    Some ASF projects are using appveyor CI for windows testing. FYI
    
    https://blogs.apache.org/infra/entry/appveyor_ci_now_available_for
    https://github.com/apache/thrift/blob/master/appveyor.yml



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 I think it's hard to test these binaries on the current Travis. So, we must manually tests them before these binaries are included.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382  BTW, what's the result of `ldd libxgboost4j.so` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 Aha, I've not seen that exception. Actually, I didn't check behaviours in Hive. Could you look into this issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by amaya382 <gi...@git.apache.org>.
Github user amaya382 commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @myui I see
    No. If need be, I'll open it as a new PR


---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @maropu It seems it's not hive specific issue but not label set is the training dataset.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r117690004
  
    --- Diff: bin/build_xgboost.sh ---
    @@ -1,87 +0,0 @@
    -#!/bin/bash
    -#
    -# Licensed to the Apache Software Foundation (ASF) under one
    -# or more contributor license agreements.  See the NOTICE file
    -# distributed with this work for additional information
    -# regarding copyright ownership.  The ASF licenses this file
    -# to you under the Apache License, Version 2.0 (the
    -# "License"); you may not use this file except in compliance
    -# with the License.  You may obtain a copy of the License at
    -#
    -#   http://www.apache.org/licenses/LICENSE-2.0
    -#
    -# Unless required by applicable law or agreed to in writing,
    -# software distributed under the License is distributed on an
    -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    -# KIND, either express or implied.  See the License for the
    -# specific language governing permissions and limitations
    -# under the License.
    -#
    -
    -# xgboost requires g++-4.6 or higher (https://github.com/dmlc/xgboost/blob/master/doc/build.md),
    -# so we need to first check if the requirement is satisfied.
    -COMPILER_REQUIRED_VERSION="4.6"
    -COMPILER_VERSION=`g++ --version 2> /dev/null`
    -
    -# Check if GNU g++ installed
    -if [ $? = 127 ]; then
    --- End diff --
    
    Ah, ok. But I think we keep a script to build `xgboost` on native environments in terms of CPU optimization ( I think it'd be better to follow the same approach with `snappy-java`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #80: [WIP][HIVEMALL-99] Cross-compilation of...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/80#discussion_r118157439
  
    --- Diff: Makefile ---
    @@ -0,0 +1,69 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +#
    +
    +DOCKCROSS_SCRIPT := 'dockcross.bash'
    +XGBOOST_REPO := 'https://github.com/maropu/xgboost.git'
    +XGBOOST_BRANCH := 'xgboost_v0.60_with_portable_binaries'
    +HIVEMALL_HOME := "$(shell pwd)"
    +HIVEMALL_OUT := "${HIVEMALL_HOME}/target"
    +XGBOOST_OUT := "${HIVEMALL_OUT}/xgboost"
    +HIVEMALL_LIB_DIR := "${HIVEMALL_HOME}/xgboost/src/main/resources/lib"
    +CANDIDATES := 'linux-arm64' 'linux-armv6' 'linux-armv7' 'linux-ppc64le' 'linux-x64' 'linux-x86' 'windows-x64' 'windows-x86'
    --- End diff --
    
    supported platform of hivemall depends on Hadoop.
    
    target os is linux, windows, mac osx.
    main target platform is x86, x64.
    
    mac osx support is only used for local testing though.
    https://github.com/xerial/snappy-java/blob/master/Makefile#L167
    https://github.com/multiarch/crossbuild


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    @amaya382 considering to build multiple shared libraries in resource directory as seen in 
    https://github.com/xerial/snappy-java/tree/master/src/main/resources/org/xerial/snappy/native


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #80: [WIP][HIVEMALL-99] Cross-compilation of XGBoos...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/80
  
    
    [![Coverage Status](https://coveralls.io/builds/11618733/badge)](https://coveralls.io/builds/11618733)
    
    Coverage decreased (-0.04%) to 38.657% when pulling **89bc62bc8ee080527d851b8d82c4d1fa29c80ab7 on amaya382:cross-compiling** into **10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---