You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2015/05/13 17:29:28 UTC

Review Request 34168: [FALCON-1216] Cluster setup wizard tests for default and xmlPreview scenarios

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34168/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1216
    https://issues.apache.org/jira/browse/FALCON-1216


Repository: falcon-git


Description
-------

Cluster setup wizard tests for default and xmlPreview scenarios


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java 5acf1eb 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/UIAssert.java f4befd4 
  falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java PRE-CREATION 
  falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewClusterPage.java fa8349b 
  falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 0a41a5e 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/34168/diff/


Testing
-------

Currently testDefaultScenario and testXmlPreview fail due to UI issues.


Thanks,

Paul Isaychuk

Re: Review Request 34168: [FALCON-1216] Cluster setup wizard tests for default and xmlPreview scenarios

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.


> On May 19, 2015, 3:06 p.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 442
> > <https://reviews.apache.org/r/34168/diff/3/?file=961541#file961541line442>
> >
> >     findElement "//div[@id='interfaces-detail'][6]//div[@class='col-xs-16']/input"

better one "//div[@id='interfaces-detail'][6]//input[@ng-model='_interface._endpoint']"


> On May 19, 2015, 3:06 p.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 443
> > <https://reviews.apache.org/r/34168/diff/3/?file=961541#file961541line443>
> >
> >     findElement "//div[@id='interfaces-detail'][6]//div[@class='col-xs-4']/input"

better one "//div[@id='interfaces-detail'][6]//input[@ng-model='_interface._version']"


- Ruslan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34168/#review84309
-----------------------------------------------------------


On May 15, 2015, 7:49 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34168/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 7:49 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1216
>     https://issues.apache.org/jira/browse/FALCON-1216
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Cluster setup wizard tests for default and xmlPreview scenarios
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java 5acf1eb 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/UIAssert.java f4befd4 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java PRE-CREATION 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewClusterPage.java fa8349b 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java c166eaf 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/ELbundle/cluster-0.1.xml 6478384 
> 
> Diff: https://reviews.apache.org/r/34168/diff/
> 
> 
> Testing
> -------
> 
> testAddDeleteLocation fails due to UI issue.
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>

Re: Review Request 34168: [FALCON-1216] Cluster setup wizard tests for default and xmlPreview scenarios

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34168/#review84309
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java
<https://reviews.apache.org/r/34168/#comment135530>

    difficult to read
    maybe something like this:
    
        if (srcLocations.size() != objLocations.size()) {
            return false;
        }
        nextType:
        for (ClusterLocationType type : ClusterLocationType.values()) {
            List<Location> locations1 = new ArrayList<>();
            List<Location> locations2 = new ArrayList<>();
            //get locations of the same type
            for (int i = 0; i < srcLocations.size(); i++) {
                if (srcLocations.get(i).getName() == type) {
                    locations1.add(srcLocations.get(i));
                }
                if (objLocations.get(i).getName() == type) {
                    locations2.add(objLocations.get(i));
                }
            }
            if (locations1.size() != locations2.size()) {
                return false;
            }
    
            //compare locations of the same type. At least 1 match should be present.
            for(Location location1: locations1) {
                for(Location location2 : locations2) {
                    if (location1.getPath().equals(location2.getPath())) {
                        continue nextType; //match found, try next type
                    }
                }
            }
            return false;
        }
    
        return true;



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/UIAssert.java
<https://reviews.apache.org/r/34168/#comment135531>

    we have this in Page.java



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java
<https://reviews.apache.org/r/34168/#comment135525>

    findElement "//div[@id='interfaces-detail'][6]//div[@class='col-xs-16']/input"



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java
<https://reviews.apache.org/r/34168/#comment135526>

    findElement "//div[@id='interfaces-detail'][6]//div[@class='col-xs-4']/input"



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java
<https://reviews.apache.org/r/34168/#comment135523>

    should be "/tmp"


- Ruslan Ostafiychuk


On May 15, 2015, 7:49 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34168/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 7:49 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1216
>     https://issues.apache.org/jira/browse/FALCON-1216
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Cluster setup wizard tests for default and xmlPreview scenarios
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java 5acf1eb 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/UIAssert.java f4befd4 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java PRE-CREATION 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewClusterPage.java fa8349b 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java c166eaf 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/ELbundle/cluster-0.1.xml 6478384 
> 
> Diff: https://reviews.apache.org/r/34168/diff/
> 
> 
> Testing
> -------
> 
> testAddDeleteLocation fails due to UI issue.
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>