You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2011/06/04 05:25:47 UTC
[jira] [Created] (CASSANDRA-2740) nodetool decommission should
throw an error when there are extra params
nodetool decommission should throw an error when there are extra params
-----------------------------------------------------------------------
Key: CASSANDRA-2740
URL: https://issues.apache.org/jira/browse/CASSANDRA-2740
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Brandon Williams
Priority: Trivial
Fix For: 0.7.7
removetoken takes a token parameter, but decommission works against the node where the call is issued. This allows confusion such as 'nodetool -h localhost decommission <ip or token>' actually decommissioning the local node, instead of whatever was passed to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2740) nodetool decommission should
throw an error when there are extra params
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046877#comment-13046877 ]
Brandon Williams commented on CASSANDRA-2740:
---------------------------------------------
For 1.0 I'd like to see decom work like rt, and take a token parameter, but I don't want to break existing jmx tools for 0.8, so let's just error on extra params there.
> nodetool decommission should throw an error when there are extra params
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-2740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2740
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Brandon Williams
> Assignee: Jon Hermes
> Priority: Trivial
> Fix For: 0.7.7
>
>
> removetoken takes a token parameter, but decommission works against the node where the call is issued. This allows confusion such as 'nodetool -h localhost decommission <ip or token>' actually decommissioning the local node, instead of whatever was passed to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2740) nodetool decommission should
throw an error when there are extra params
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-2740:
----------------------------------
Attachment: 2740.txt
All zero-arg commands now complain when there's extra args.
> nodetool decommission should throw an error when there are extra params
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-2740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2740
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Brandon Williams
> Assignee: Jon Hermes
> Priority: Trivial
> Fix For: 0.7.7
>
> Attachments: 2740.txt
>
>
> removetoken takes a token parameter, but decommission works against the node where the call is issued. This allows confusion such as 'nodetool -h localhost decommission <ip or token>' actually decommissioning the local node, instead of whatever was passed to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2740) nodetool decommission should
throw an error when there are extra params
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065624#comment-13065624 ]
Hudson commented on CASSANDRA-2740:
-----------------------------------
Integrated in Cassandra-0.7 #528 (See [https://builds.apache.org/job/Cassandra-0.7/528/])
Do not allow extra params to nodetool commands to prevent confusion.
Patch by Jon Hermes, reviewed by brandonwilliams for CASSANDRA-2740
brandonwilliams : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146923
Files :
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/tools/NodeCmd.java
> nodetool decommission should throw an error when there are extra params
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-2740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2740
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Brandon Williams
> Assignee: Jon Hermes
> Priority: Trivial
> Fix For: 0.7.8
>
> Attachments: 2740.txt
>
>
> removetoken takes a token parameter, but decommission works against the node where the call is issued. This allows confusion such as 'nodetool -h localhost decommission <ip or token>' actually decommissioning the local node, instead of whatever was passed to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2740) nodetool decommission should
throw an error when there are extra params
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2740:
--------------------------------------
Reviewer: brandon.williams
> nodetool decommission should throw an error when there are extra params
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-2740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2740
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Brandon Williams
> Assignee: Jon Hermes
> Priority: Trivial
> Fix For: 0.7.7
>
> Attachments: 2740.txt
>
>
> removetoken takes a token parameter, but decommission works against the node where the call is issued. This allows confusion such as 'nodetool -h localhost decommission <ip or token>' actually decommissioning the local node, instead of whatever was passed to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-2740) nodetool decommission should
throw an error when there are extra params
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes reassigned CASSANDRA-2740:
-------------------------------------
Assignee: Jon Hermes
> nodetool decommission should throw an error when there are extra params
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-2740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2740
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Brandon Williams
> Assignee: Jon Hermes
> Priority: Trivial
> Fix For: 0.7.7
>
>
> removetoken takes a token parameter, but decommission works against the node where the call is issued. This allows confusion such as 'nodetool -h localhost decommission <ip or token>' actually decommissioning the local node, instead of whatever was passed to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2740) nodetool decommission should
throw an error when there are extra params
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046880#comment-13046880 ]
Jonathan Ellis commented on CASSANDRA-2740:
-------------------------------------------
why add token param?
> nodetool decommission should throw an error when there are extra params
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-2740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2740
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Brandon Williams
> Assignee: Jon Hermes
> Priority: Trivial
> Fix For: 0.7.7
>
>
> removetoken takes a token parameter, but decommission works against the node where the call is issued. This allows confusion such as 'nodetool -h localhost decommission <ip or token>' actually decommissioning the local node, instead of whatever was passed to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira