You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/05 18:10:45 UTC

[GitHub] [kafka] vamossagar12 commented on pull request #12826: Using Timer class to track expiry in IncrementalCooperativeAssignor

vamossagar12 commented on PR #12826:
URL: https://github.com/apache/kafka/pull/12826#issuecomment-1304603537

   Hey @C0urante , I created this draft PR to use `Timer` constructs in `IncrementalCooperativeAssignor`. I have added the rationale as well. You could argue that why fix something which is not broken as well :) but I thought it makes sense to do this. Let me know what you think about it.
   
   PS: I haven't added any new tests as with this change, the tests/end users shouldn't notice any difference. I ran all tests locally and they seemed to have passed which should be enough IMO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org