[GitHub] eolivelli commented on a change in pull request #853: WiP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #853: WiP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation
URL: https://github.com/apache/bookkeeper/pull/853#discussion_r186290984
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
 ##########
 @@ -1444,17 +1460,23 @@ void sendAddSuccessCallbacks() {
                 return;
             }
             // Check if it is the next entry in the sequence.
-            if (pendingAddOp.entryId != 0 && pendingAddOp.entryId != lastAddConfirmed + 1) {
+            if (pendingAddOp.entryId != 0 && pendingAddOp.entryId != pendingAddsSequenceHead) {
 
 Review comment:
   we decided to drop the concept of server side LastAddSynced, so this *pendingAddsSequenceHead* is fine in my opinion. IT is like what @jvrao is calling "nonDurableLAC"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services