You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/01 05:49:26 UTC

[GitHub] [arrow] rjzamora opened a new pull request #8809: Fix RowGroupInfo.statistics for empty row groups

rjzamora opened a new pull request #8809:
URL: https://github.com/apache/arrow/pull/8809


   Simple fix to avoid calling `statistics.has_min_max` when `statistics == None` in `RowGroupInfo.statistics`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche closed pull request #8809: ARROW-10778: [Python] Fix RowGroupInfo.statistics for empty row groups

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #8809:
URL: https://github.com/apache/arrow/pull/8809


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8809: ARROW-10778: [Python] Fix RowGroupInfo.statistics for empty row groups

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #8809:
URL: https://github.com/apache/arrow/pull/8809#discussion_r533291547



##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -929,7 +929,8 @@ class RowGroupInfo:
         def name_stats(i):
             col = self.metadata.column(i)
 
-            if not col.statistics.has_min_max:
+            stats = col.statistics
+            if stats is None or not stats.has_min_max:

Review comment:
       Another option would be to check `col.is_stats_set`, but that results in `col.statistics` being None, so this is just as good




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8809: Fix RowGroupInfo.statistics for empty row groups

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8809:
URL: https://github.com/apache/arrow/pull/8809#issuecomment-736244736


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8809: ARROW-10778: [Python] Fix RowGroupInfo.statistics for empty row groups

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8809:
URL: https://github.com/apache/arrow/pull/8809#issuecomment-736372323


   https://issues.apache.org/jira/browse/ARROW-10778


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org