You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/10/29 09:03:15 UTC
[GitHub] [ignite] sanpwc opened a new pull request #8406: IGNITE-13640 copy-libs plugin added.
sanpwc opened a new pull request #8406:
URL: https://github.com/apache/ignite/pull/8406
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [] There is a single JIRA ticket related to the pull request.
- [] The web-link to the pull request is attached to the JIRA ticket.
- [] The JIRA ticket has the _Patch Available_ state.
- [] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nva commented on a change in pull request #8406: IGNITE-13640 copy-libs plugin added.
Posted by GitBox <gi...@apache.org>.
nva commented on a change in pull request #8406:
URL: https://github.com/apache/ignite/pull/8406#discussion_r514176161
##########
File path: modules/opencensus/pom.xml
##########
@@ -116,4 +116,27 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-libs</id>
+ <phase>test-compile</phase>
+ <goals>
+ <goal>copy-dependencies</goal>
+ </goals>
+ <configuration>
+ <excludeGroupIds>org.gridgain</excludeGroupIds>
+ <outputDirectory>target/libs/optional</outputDirectory>
Review comment:
```suggestion
<outputDirectory>target/libs</outputDirectory>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8406: IGNITE-13640 copy-libs plugin added.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8406:
URL: https://github.com/apache/ignite/pull/8406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #8406: IGNITE-13640 copy-libs plugin added.
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #8406:
URL: https://github.com/apache/ignite/pull/8406#discussion_r516028426
##########
File path: modules/opencensus/pom.xml
##########
@@ -116,4 +116,27 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-libs</id>
+ <phase>test-compile</phase>
+ <goals>
+ <goal>copy-dependencies</goal>
+ </goals>
+ <configuration>
+ <excludeGroupIds>org.gridgain</excludeGroupIds>
Review comment:
Do we really need this? It seems all _vendor-specific_ things must be excluded from the pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sanpwc commented on a change in pull request #8406: IGNITE-13640 copy-libs plugin added.
Posted by GitBox <gi...@apache.org>.
sanpwc commented on a change in pull request #8406:
URL: https://github.com/apache/ignite/pull/8406#discussion_r517846241
##########
File path: modules/opencensus/pom.xml
##########
@@ -116,4 +116,27 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-libs</id>
+ <phase>test-compile</phase>
+ <goals>
+ <goal>copy-dependencies</goal>
+ </goals>
+ <configuration>
+ <excludeGroupIds>org.gridgain</excludeGroupIds>
Review comment:
My fault. Fixed. `<excludeGroupIds>org.gridgain</excludeGroupIds>` -> `<excludeGroupIds>org.apache.ignite</excludeGroupIds>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sk0x50 commented on a change in pull request #8406: IGNITE-13640 copy-libs plugin added.
Posted by GitBox <gi...@apache.org>.
sk0x50 commented on a change in pull request #8406:
URL: https://github.com/apache/ignite/pull/8406#discussion_r534089525
##########
File path: modules/opencensus/pom.xml
##########
@@ -116,4 +116,27 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-libs</id>
+ <phase>test-compile</phase>
Review comment:
Hello @Mmuzaf ,
>why phase test-compile instead of package?
Changed to `package`. Thank you!
> all the opencensus libs will be available at libs directory by default, right?
All libs will be placed at `libs/optional/ignite-opencensus` in the release build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #8406: IGNITE-13640 copy-libs plugin added.
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #8406:
URL: https://github.com/apache/ignite/pull/8406#discussion_r518288771
##########
File path: modules/opencensus/pom.xml
##########
@@ -116,4 +116,27 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-libs</id>
+ <phase>test-compile</phase>
Review comment:
Can you clarify the following questions, please:
- why phase `test-compile` instead of `package`?
- all the `opencensus` libs will be available at `libs` directory by default, right? should we copy them from e.g. `libs/opencensus` directory only when this integration is used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org