You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/22 05:24:47 UTC
[GitHub] [superset] zuzana-vej opened a new pull request #14298: chore: SQLLab row limit warning using Alert component
zuzana-vej opened a new pull request #14298:
URL: https://github.com/apache/superset/pull/14298
### SUMMARY
The longer warning message was using the new Alert component, but the warning message when rows were limited on result (not just what was displayed on UI) was not using the new Alert component. This PR addresses that for consistency.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="599" alt="before" src="https://user-images.githubusercontent.com/61221714/115659851-03879500-a2f0-11eb-9072-f22a4d80ec78.png">
After:
<img width="1257" alt="after" src="https://user-images.githubusercontent.com/61221714/115659841-01253b00-a2f0-11eb-8fa4-0974a7b59a30.png">
### TEST PLAN
Tested on local
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay edited a comment on pull request #14298: chore: SQLLab row limit warning using Alert component
Posted by GitBox <gi...@apache.org>.
Steejay edited a comment on pull request #14298:
URL: https://github.com/apache/superset/pull/14298#issuecomment-827754026
Understood. Did the users miss the rows returned indicator too ("1000 rows returned")?
Does this framework work?:
When a limit is defined by the default 1000 dropdown= warning
When a limit is defined by a config on the server side = warning
When a limit is defined by the user changing the limit dropdown selection = no warning
When a limit is defined by the user creating it in SQL editor = no warning
When a limit isnt reached because the query returned < any limits applied = no warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay commented on pull request #14298: chore: SQLLab row limit warning using Alert component
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #14298:
URL: https://github.com/apache/superset/pull/14298#issuecomment-827678821
@zuzana-vej
I dont think all limit indicators should be in an alert state. we want to avoid adding disruptive messaging every time a user runs a query.
there were 2 states we looked at when designing this message. First was a general limit indicator that is supposed to give non disruptive feedback to the user that x amount of rows were returned based on a limit constraint they applied in the UI somewhere (sql or dropdown).
The second state is when a limit was applied based on a limit constraint configured on the server side (something a non admin could not see in the UI). For this state an alert was used to bring attention to the user that if they are seeing a row llimit that isnt shown in the UI its because of a configuration on the server side. hence the alert state (and improved copy you suggested in a previous issue).
cc @AAfghahi @yousoph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej merged pull request #14298: chore: SQLLab row limit warning using Alert component
Posted by GitBox <gi...@apache.org>.
zuzana-vej merged pull request #14298:
URL: https://github.com/apache/superset/pull/14298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on pull request #14298: chore: SQLLab row limit warning using Alert component
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on pull request #14298:
URL: https://github.com/apache/superset/pull/14298#issuecomment-827744396
I agree that sometimes limit is intentional and then it shouldn't be a warning. However the 1000 limit is default, many users don't realize this, and they query the data, sort through the displayed table not seeing what expected, or they download to CSV only to realize that they only downloaded 1000 records and they need to rerun the query again.
Based on this user feedback, when the 1000 limit was applied due to the default dropdown it should be a warning.
If there is N rows displayed because the query simply just returned 345 records, then I agree it shouldn't be a warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay commented on pull request #14298: chore: SQLLab row limit warning using Alert component
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #14298:
URL: https://github.com/apache/superset/pull/14298#issuecomment-827754026
Understood. Does this framework work?:
When a limit is defined by the default 1000 dropdown= warning
When a limit is defined by a config on the server side = warning
When a limit is defined by the user changing the limit dropdown selection = no warning
When a limit is defined by the user creating it in SQL editor = no warning
When a limit isnt reached because the query returned < any limits applied = no warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #14298: chore: SQLLab row limit warning using Alert component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14298:
URL: https://github.com/apache/superset/pull/14298#issuecomment-824994829
# [Codecov](https://codecov.io/gh/apache/superset/pull/14298?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14298](https://codecov.io/gh/apache/superset/pull/14298?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09f61b9) into [master](https://codecov.io/gh/apache/superset/commit/5d3191bb612ad4872ba7f77c2adab91d2f7146a5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d3191b) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/14298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14298 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 954 954
Lines 48070 48071 +1
Branches 5973 5974 +1
=======================================
+ Hits 36982 36983 +1
- Misses 10886 10891 +5
+ Partials 202 197 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.10% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/14298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `70.00% <100.00%> (+0.13%)` | :arrow_up: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/14298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `64.28% <0.00%> (ø)` | |
| [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `33.33% <0.00%> (ø)` | |
| [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `33.33% <0.00%> (ø)` | |
| [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `33.33% <0.00%> (ø)` | |
| [...ts/nativeFilters/FilterBar/FilterControls/state.ts](https://codecov.io/gh/apache/superset/pull/14298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL3N0YXRlLnRz) | `80.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14298?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14298?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5d3191b...09f61b9](https://codecov.io/gh/apache/superset/pull/14298?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay commented on pull request #14298: chore: SQLLab row limit warning using Alert component
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #14298:
URL: https://github.com/apache/superset/pull/14298#issuecomment-827758903
I think there also needs to be more work done on the hierarchy of the SQL Lab controls. If users are missing the limit dropdown which has a default applied then that seems like one of the root problems to solve here. Generally, I dont love how the default options would send an alert to the user. But this could be a fix for now to at least bring attention to an important control to the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on pull request #14298: chore: SQLLab row limit warning using Alert component
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on pull request #14298:
URL: https://github.com/apache/superset/pull/14298#issuecomment-827926647
@zuzana-vej @Steejay
I implemented these changes here:
https://github.com/apache/superset/pull/14381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org