You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/11/16 21:15:17 UTC
[GitHub] [incubator-eventmesh] jinrongluo opened a new pull request #594: [Issue #417] gRPC design doc and protobuf models
jinrongluo opened a new pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594
Fixes ISSUE #417.
### Motivation
- use gRPC protocol to support polyglot eventmesh client SDK
### Modifications
- gRPC protocol design doc
- gRPC protobuf model
- gRPC protobuf code generation
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-973652561
> @jinrongluo if grpc implementation is a plugin, there may need a api for grpc/http/tcp etc.
@jinrongluo we may discuss this first before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-971115920
> What went wrong: Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0. Execution failed for task ':checkLicense'. Use '--warning-mode all' to show the individual deprecation warnings.
>
> @qqeasonchen I think we have some improvement when resorting to GitHub's building checks.
@keranbingaa can you help to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-971076509
You could refer here to exclude the grpc auto-created file from the general check from ck. https://docs.gradle.org/current/userguide/checkstyle_plugin.html#sec:checkstyle_tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling edited a comment on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
vongosling edited a comment on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-971076509
You could refer here to exclude the grpc auto-created files from ck. https://docs.gradle.org/current/userguide/checkstyle_plugin.html#sec:checkstyle_tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-972420617
@jinrongluo We could move code to grpc branch temporarily, review after merge @qqeasonchen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-973029969
> >  this is the reason for CI/CD check failed, please excute `gradlew checkLicense` task, check the licenses in the `..\incubator-eventmesh\build\reports\dependency-license\dependencies-without-allowed-license.json` file, if theses licenses are allowed, please copy these texts into `..\tool\license\allowed-licenses.txt`
>
> @jinrongluo maybe you need do this to solve the failed check
Thanks @keranbingaa I adding the allowed licenses for grpc and protobuf.
the commit is here - https://github.com/apache/incubator-eventmesh/pull/594/commits/0ef7783ff11fb01671c0e540db50df0cc1e2ba19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-973029540
> >  this is the reason for CI/CD check failed, please excute `gradlew checkLicense` task, check the licenses in the `..\incubator-eventmesh\build\reports\dependency-license\dependencies-without-allowed-license.json` file, if theses licenses are allowed, please copy these texts into `..\tool\license\allowed-licenses.txt`
>
> @jinrongluo maybe you need do this to solve the failed check
Thanks @keranbingaa I adding the allowed licenses for grpc and protobuf.
the commit is here - https://github.com/apache/incubator-eventmesh/pull/594/commits/0ef7783ff11fb01671c0e540db50df0cc1e2ba19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] keranbingaa commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
keranbingaa commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-971226439
@vongosling @qqeasonchen ok，I will try to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-971088308
What went wrong:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
Execution failed for task ':checkLicense'.
Use '--warning-mode all' to show the individual deprecation warnings.
@qqeasonchen I think we have some improvement when resorting to GitHub's building checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling edited a comment on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
vongosling edited a comment on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-972420617
@jinrongluo We could move code to grpc branch temporarily, review after merge @qqeasonchen But first now, we should resolve 2 failure checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-973794723
> > @jinrongluo if grpc implementation is a plugin, there may need a api for grpc/http/tcp etc.
>
> @jinrongluo we may discuss this first before merge.
Glad to see the sdk-gprc implementation, runtime implementation will commit later, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-971114715
@jinrongluo if grpc implementation is a plugin, there may need a api for grpc/http/tcp etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-971123604
> > What went wrong: Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0. Execution failed for task ':checkLicense'. Use '--warning-mode all' to show the individual deprecation warnings.
> > @qqeasonchen I think we have some improvement when resorting to GitHub's building checks.
>
> @keranbingaa can you help to fix it?
https://docs.gradle.org/7.3/userguide/compatibility.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-974161520
> > @jinrongluo if grpc implementation is a plugin, there may need a api for grpc/http/tcp etc.
>
> @jinrongluo we may discuss this first before merge.
I agree. in the actual grpc implementation, I will use plugins. This PR is only about design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-975115330
> > > @jinrongluo if grpc implementation is a plugin, there may need a api for grpc/http/tcp etc.
> >
> >
> > @jinrongluo we may discuss this first before merge.
>
> I agree. in the actual grpc implementation, I will use plugins. This PR is only about design.
ok, then it can be merged first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-972437413
this is the reason for CI/CD check failed, please excute `gradlew checkLicense` task, check the licenses in the `..\incubator-eventmesh\build\reports\dependency-license\dependencies-without-allowed-license.json` file, if theses licenses are allowed, please copy these texts into `..\tool\license\allowed-licenses.txt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo removed a comment on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
jinrongluo removed a comment on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-973029969
> >  this is the reason for CI/CD check failed, please excute `gradlew checkLicense` task, check the licenses in the `..\incubator-eventmesh\build\reports\dependency-license\dependencies-without-allowed-license.json` file, if theses licenses are allowed, please copy these texts into `..\tool\license\allowed-licenses.txt`
>
> @jinrongluo maybe you need do this to solve the failed check
Thanks @keranbingaa I adding the allowed licenses for grpc and protobuf.
the commit is here - https://github.com/apache/incubator-eventmesh/pull/594/commits/0ef7783ff11fb01671c0e540db50df0cc1e2ba19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-981558114
It's important to note that this is quite a difficult refactoring. you could refer quarkus codes. https://quarkus.io/guides/grpc-getting-started.
I'd like to help to opt code for this feature, looking forwards to your code :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] keranbingaa commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
keranbingaa commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-972841706
>  this is the reason for CI/CD check failed, please excute `gradlew checkLicense` task, check the licenses in the `..\incubator-eventmesh\build\reports\dependency-license\dependencies-without-allowed-license.json` file, if theses licenses are allowed, please copy these texts into `..\tool\license\allowed-licenses.txt`
@jinrongluo maybe you need do this to solve the failed check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594#issuecomment-974160576
> > > @jinrongluo if grpc implementation is a plugin, there may need a api for grpc/http/tcp etc.
> >
> >
> > @jinrongluo we may discuss this first before merge.
>
> Glad to see the sdk-gprc implementation, runtime implementation will commit later, right?
Yes, @qqeasonchen this PR is about protobuff message design. the actual implementation will be coming in next PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #594: [Issue #417] gRPC design doc and protobuf models
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged pull request #594:
URL: https://github.com/apache/incubator-eventmesh/pull/594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org