You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2021/08/31 16:31:21 UTC

[hbase] branch branch-2 updated: HBASE-25642 Fix or stop warning about already cached block (#3638)

This is an automated email from the ASF dual-hosted git repository.

apurtell pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new 8be2ad2  HBASE-25642 Fix or stop warning about already cached block (#3638)
8be2ad2 is described below

commit 8be2ad2d42294da3ae6230572b9d3ecda28cc786
Author: Andrew Purtell <ap...@apache.org>
AuthorDate: Tue Aug 31 09:25:31 2021 -0700

    HBASE-25642 Fix or stop warning about already cached block (#3638)
    
    Our logs have as a fairly common occurrence: 2021-03-05 22:24:31,034 WARN
    [StoreFileOpener-foo-1] hfile.BlockCacheUtil: Caching an already cached
    block: blah.bub. This is harmless and can happen in rare cases (see HBASE-8547)
    
    Because it is harmless, log at DEBUG level, not WARN.
    
    Signed-off-by: Baiqiang Zhao <zh...@apache.org>
    Signed-off-by: Duo Zhang <zh...@apache.org>
    Signed-off-by: Viraj Jasani <vj...@apache.org>
    Reviewed-by: Rushabh Shah <ru...@salesforce.com>
---
 .../src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
index 2672992..c2cf821 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
@@ -244,7 +244,7 @@ public class BlockCacheUtil {
             + "nextBlockOnDiskSize set, Keeping cached block.");
         return false;
       } else {
-        LOG.warn("Caching an already cached block: {}. This is harmless and can happen in rare "
+        LOG.debug("Caching an already cached block: {}. This is harmless and can happen in rare "
             + "cases (see HBASE-8547)",
           cacheKey);
         return false;