You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/30 16:23:05 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #7611:
[sqllab] Cancel database query on stop
codecov-io edited a comment on issue #7611: [sqllab] Cancel database query on stop
URL: https://github.com/apache/incubator-superset/pull/7611#issuecomment-497071895
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7611?src=pr&el=h1) Report
> Merging [#7611](https://codecov.io/gh/apache/incubator-superset/pull/7611?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7f17ba7ee238516cd025031f31e39a1db8d89a9a?src=pr&el=desc) will **decrease** coverage by `7.89%`.
> The diff coverage is `51.51%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7611?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7611 +/- ##
=========================================
- Coverage 73.75% 65.85% -7.9%
=========================================
Files 115 459 +344
Lines 12059 22019 +9960
Branches 0 2415 +2415
=========================================
+ Hits 8894 14501 +5607
- Misses 3165 7397 +4232
- Partials 0 121 +121
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7611?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.02% <0%> (+1.56%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `94.8% <100%> (+0.06%)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `73.3% <40%> (-4.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `90% <71.42%> (-2.16%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.76% <75%> (-1.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | `50% <0%> (-15%)` | :arrow_down: |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `46.66% <0%> (-11.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `45% <0%> (-9.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | `45.45% <0%> (-8.4%)` | :arrow_down: |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `44.82% <0%> (-7.42%)` | :arrow_down: |
| ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/7611/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7611?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7611?src=pr&el=footer). Last update [7f17ba7...085fff0](https://codecov.io/gh/apache/incubator-superset/pull/7611?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org