You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jeremycostanzo (via GitHub)" <gi...@apache.org> on 2025/07/18 09:45:43 UTC

[PR] GH-47131: [C#] Fix day off by 1 in Date64Array [arrow]

jeremycostanzo opened a new pull request, #47132:
URL: https://github.com/apache/arrow/pull/47132

   ### Rationale for this change
   `Date64Array.Convert(DateTimeOffset)` substracts one day on date times that are at 00:00 am and < 1970.
   For example, 01/01/1969 00:00:00 gets converted to 12/31/1968 whereas the expected result is 01/01/1969.
   
   ### What changes are included in this PR?
   Fix to the described bug.
   
   ### Are these changes tested?
   Yes
   
   ### Are there any user-facing changes?
   No
   
   **This PR contains a "Critical Fix".** 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-47131: [C#] Fix day off by 1 in Date64Array [arrow]

Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #47132:
URL: https://github.com/apache/arrow/pull/47132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-47131: [C#] Fix day off by 1 in Date64Array [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47132:
URL: https://github.com/apache/arrow/pull/47132#issuecomment-3088834787

   :warning: GitHub issue #47131 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-47131: [C#] Fix day off by 1 in Date64Array [arrow]

Posted by "jeremycostanzo (via GitHub)" <gi...@apache.org>.
jeremycostanzo commented on PR #47132:
URL: https://github.com/apache/arrow/pull/47132#issuecomment-3088842982

   With the added test cases and without the fix,
   `Date64ArrayTest.AppendGivesUtcDate(dateTimeOffset: 1969-12-31T00:00:00.0000000+00:00)` fails with
   ```
   Assert.Equal() Failure: Values differ
   Expected: 1969-12-31T00:00:00.0000000Z
   Actual:   1969-12-30T00:00:00.0000000
   ```
   
   `Date64ArrayTest.AppendGivesUtcDate(dateTimeOffset: 0001-01-01T00:00:00.0000000+00:00)` fails with
   ```
   System.ArgumentOutOfRangeException: Valid values are between -62135596800000 and 253402300799999, inclusive. (Parameter 'milliseconds')
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org