You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/03 03:27:52 UTC

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #903: [Issue 183] [Feat] Support cumulative acknowledge

Gleiphir2769 commented on code in PR #903:
URL: https://github.com/apache/pulsar-client-go/pull/903#discussion_r1060259306


##########
pulsar/impl_message_test.go:
##########
@@ -80,6 +80,12 @@ func TestAckTracker(t *testing.T) {
 
 	}
 	assert.Equal(t, true, tracker.completed())
+
+	// test large number 1000 cumulative
+	tracker = newAckTracker(1000)
+
+	assert.Equal(t, true, tracker.ackCumulative(999))

Review Comment:
   Good suggestion! I will add test code to cover the cumulative tracker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org