You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "paul bolger (JIRA)" <ji...@apache.org> on 2006/03/10 03:33:38 UTC
[jira] Created: (FOR-827) Weirdness in CSS after url
Weirdness in CSS after url
--------------------------
Key: FOR-827
URL: http://issues.apache.org/jira/browse/FOR-827
Project: Forrest
Type: Bug
Components: Dispatcher (aka views)
Versions: 0.8-dev
Reporter: paul bolger
Priority: Minor
Don't quite understand were this is coming from. It appears that Forrest is trying to improve on my stylesheets...
If a stylesheet contains a a URL, when referencing a background image in this particular case, Forrest inserts an extra semicolon after the closing bracket containing the URL. This is get-roundable normally, skip the semicolon, but it prevent the use of the shorthand background property as the semicolon truncates the rule.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (FOR-827) Weirdness in CSS after url
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-827?page=all ]
Thorsten Scherler closed FOR-827.
---------------------------------
Resolution: Fixed
Like seen in FOR-745 and FOR-744 this should be fixed.
I tried to reproduce it in current dispatcher and I could not.
Closing it.
> Weirdness in CSS after url
> --------------------------
>
> Key: FOR-827
> URL: http://issues.apache.org/jira/browse/FOR-827
> Project: Forrest
> Issue Type: Bug
> Components: Dispatcher (aka views)
> Affects Versions: 0.8-dev
> Reporter: paul bolger
> Priority: Minor
>
> Don't quite understand were this is coming from. It appears that Forrest is trying to improve on my stylesheets...
> If a stylesheet contains a a URL, when referencing a background image in this particular case, Forrest inserts an extra semicolon after the closing bracket containing the URL. This is get-roundable normally, skip the semicolon, but it prevent the use of the shorthand background property as the semicolon truncates the rule.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-827?page=comments#action_12370331 ]
Gavin commented on FOR-827:
---------------------------
Try surrounding the url in quotes, worked for me, also is recomended use by W3C and ensures cross-browser compatibility.
Something like :-
background: url("/images/tednoffsfoundation.jpg") top left no-repeat;
Otherwise, what hook/div is it contained it, this will help narrow it down as to waht .ft file to look in for possibilities.
For instance, there are plenty of these knocking around :-
background: <xsl:value-of select="@value"/>;
Note the addition of a semi-colon at the end.
> Weirdness in CSS after url
> --------------------------
>
> Key: FOR-827
> URL: http://issues.apache.org/jira/browse/FOR-827
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views)
> Versions: 0.8-dev
> Reporter: paul bolger
> Priority: Minor
>
> Don't quite understand were this is coming from. It appears that Forrest is trying to improve on my stylesheets...
> If a stylesheet contains a a URL, when referencing a background image in this particular case, Forrest inserts an extra semicolon after the closing bracket containing the URL. This is get-roundable normally, skip the semicolon, but it prevent the use of the shorthand background property as the semicolon truncates the rule.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-827?page=comments#action_12370270 ]
Gavin commented on FOR-827:
---------------------------
Sorry Paul, can not see where this is happening at the moment.
Can you provide the code you are using and where you are using it?
Are you using default or Pelt theme or your own theme?
Thanks
Gav...
> Weirdness in CSS after url
> --------------------------
>
> Key: FOR-827
> URL: http://issues.apache.org/jira/browse/FOR-827
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views)
> Versions: 0.8-dev
> Reporter: paul bolger
> Priority: Minor
>
> Don't quite understand were this is coming from. It appears that Forrest is trying to improve on my stylesheets...
> If a stylesheet contains a a URL, when referencing a background image in this particular case, Forrest inserts an extra semicolon after the closing bracket containing the URL. This is get-roundable normally, skip the semicolon, but it prevent the use of the shorthand background property as the semicolon truncates the rule.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "paul bolger (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-827?page=comments#action_12370277 ]
paul bolger commented on FOR-827:
---------------------------------
Code sample
this line in the stylesheet:
background: url(/images/tednoffsfoundation.jpg) top left no-repeat;
is rendered as
background: url(/images/tednoffsfoundation.jpg) ; top left no-repeat;
I'm using my own theme, but the contract in use is in common.
> Weirdness in CSS after url
> --------------------------
>
> Key: FOR-827
> URL: http://issues.apache.org/jira/browse/FOR-827
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views)
> Versions: 0.8-dev
> Reporter: paul bolger
> Priority: Minor
>
> Don't quite understand were this is coming from. It appears that Forrest is trying to improve on my stylesheets...
> If a stylesheet contains a a URL, when referencing a background image in this particular case, Forrest inserts an extra semicolon after the closing bracket containing the URL. This is get-roundable normally, skip the semicolon, but it prevent the use of the shorthand background property as the semicolon truncates the rule.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-827?page=comments#action_12413749 ]
Thorsten Scherler commented on FOR-827:
---------------------------------------
Gavin describes the perfect workaround. Thanks Gavin.
> Weirdness in CSS after url
> --------------------------
>
> Key: FOR-827
> URL: http://issues.apache.org/jira/browse/FOR-827
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views)
> Versions: 0.8-dev
> Reporter: paul bolger
> Priority: Minor
>
> Don't quite understand were this is coming from. It appears that Forrest is trying to improve on my stylesheets...
> If a stylesheet contains a a URL, when referencing a background image in this particular case, Forrest inserts an extra semicolon after the closing bracket containing the URL. This is get-roundable normally, skip the semicolon, but it prevent the use of the shorthand background property as the semicolon truncates the rule.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-827?page=comments#action_12421443 ]
Gavin commented on FOR-827:
---------------------------
So, should this workaround be documented as the way to do it, then close the issue, or does someone think there may be a better solution somewhere else?
> Weirdness in CSS after url
> --------------------------
>
> Key: FOR-827
> URL: http://issues.apache.org/jira/browse/FOR-827
> Project: Forrest
> Issue Type: Bug
> Components: Dispatcher (aka views)
> Affects Versions: 0.8-dev
> Reporter: paul bolger
> Priority: Minor
>
> Don't quite understand were this is coming from. It appears that Forrest is trying to improve on my stylesheets...
> If a stylesheet contains a a URL, when referencing a background image in this particular case, Forrest inserts an extra semicolon after the closing bracket containing the URL. This is get-roundable normally, skip the semicolon, but it prevent the use of the shorthand background property as the semicolon truncates the rule.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by Paul Bolger <pb...@gmail.com>.
Yeah, I mean I'm not sure yet. Have to backtrack a bit to check fully
as I used a workaround (did an @import within the stylesheet, thnks
diwaker)
On 14/03/06, Thorsten Scherler <th...@wyona.com> wrote:
> El mar, 14-03-2006 a las 22:29 +0930, Paul Bolger escribió:
> > The reverted version seems to be ok.
> > I'll speak up if that turns out not to be the case.
>
> jeje, no, you need to speak up if it is working for you. ;) Then I can
> apply the revert patch.
>
> TIA
>
> salu2
> --
> Thorsten Scherler
> COO Spain
> Wyona Inc. - Open Source Content Management - Apache Lenya
> http://www.wyona.com http://lenya.apache.org
> thorsten.scherler@wyona.com thorsten@apache.org
>
>
Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by Thorsten Scherler <th...@wyona.com>.
El mar, 14-03-2006 a las 22:29 +0930, Paul Bolger escribió:
> The reverted version seems to be ok.
> I'll speak up if that turns out not to be the case.
jeje, no, you need to speak up if it is working for you. ;) Then I can
apply the revert patch.
TIA
salu2
--
Thorsten Scherler
COO Spain
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
thorsten.scherler@wyona.com thorsten@apache.org
Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by Paul Bolger <pb...@gmail.com>.
The reverted version seems to be ok.
I'll speak up if that turns out not to be the case.
On 14/03/06, Thorsten Scherler <th...@wyona.com> wrote:
> El mar, 14-03-2006 a las 19:05 +0800, Gav.... escribió:
> > In pattern2link it says:-
> >
> > <!--HEADSUP: thorsten changed this because we get working inline css and
> > for static reading it should not differ( one " ;" added).
> > was:
> > <a href="{lex:group[3]}"><xsl:value-of select="lex:group[1]"/></a
> > -->
>
> jeje, nice investigation gav. ;)
>
> svn blame pattern2link.xsl
>
> 331572 thorsten <!--HEADSUP: thorsten changed this because we get
> working inline css and for static reading it should not differ( one " ;"
> added).
> 331572 thorsten was:
> 331572 thorsten <a href="{lex:group[3]}"><xsl:value-of
> select="lex:group[1]"/></a>
> 331572 thorsten -->
> 331572 thorsten <xsl:value-of select="lex:group[1]"/>;<a
> href="{lex:group[3]}"><xsl:text> </xsl:text></a>
>
>
> svn diff -r331572:232890 pattern2link.xsl
>
> Index: pattern2link.xsl
> ===================================================================
> --- pattern2link.xsl (revisión: 331572)
> +++ pattern2link.xsl (revisión: 232890)
> @@ -34,11 +34,7 @@
> </xsl:template>
>
> <xsl:template match="lex:lexeme[@symbol='cssurl']">
> - <!--HEADSUP: thorsten changed this because we get working inline css
> and for static reading it should not differ( one " ;" added).
> - was:
> - <a href="{lex:group[3]}"><xsl:value-of select="lex:group[1]"/></a>
> - -->
> - <xsl:value-of select="lex:group[1]"/>;<a
> href="{lex:group[3]}"><xsl:text> </xsl:text></a>
> + <a href="{lex:group[3]}"><xsl:value-of select="lex:group[1]"/></a>
> </xsl:template>
>
> Yeah, we should try to revert it and see what it gives. ;)
>
> Paul, can you try?
>
> salu2
> --
> Thorsten Scherler
> COO Spain
> Wyona Inc. - Open Source Content Management - Apache Lenya
> http://www.wyona.com http://lenya.apache.org
> thorsten.scherler@wyona.com thorsten@apache.org
>
>
Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by Thorsten Scherler <th...@wyona.com>.
El mar, 14-03-2006 a las 19:05 +0800, Gav.... escribió:
> In pattern2link it says:-
>
> <!--HEADSUP: thorsten changed this because we get working inline css and
> for static reading it should not differ( one " ;" added).
> was:
> <a href="{lex:group[3]}"><xsl:value-of select="lex:group[1]"/></a
> -->
jeje, nice investigation gav. ;)
svn blame pattern2link.xsl
331572 thorsten <!--HEADSUP: thorsten changed this because we get
working inline css and for static reading it should not differ( one " ;"
added).
331572 thorsten was:
331572 thorsten <a href="{lex:group[3]}"><xsl:value-of
select="lex:group[1]"/></a>
331572 thorsten -->
331572 thorsten <xsl:value-of select="lex:group[1]"/>;<a
href="{lex:group[3]}"><xsl:text> </xsl:text></a>
svn diff -r331572:232890 pattern2link.xsl
Index: pattern2link.xsl
===================================================================
--- pattern2link.xsl (revisión: 331572)
+++ pattern2link.xsl (revisión: 232890)
@@ -34,11 +34,7 @@
</xsl:template>
<xsl:template match="lex:lexeme[@symbol='cssurl']">
- <!--HEADSUP: thorsten changed this because we get working inline css
and for static reading it should not differ( one " ;" added).
- was:
- <a href="{lex:group[3]}"><xsl:value-of select="lex:group[1]"/></a>
- -->
- <xsl:value-of select="lex:group[1]"/>;<a
href="{lex:group[3]}"><xsl:text> </xsl:text></a>
+ <a href="{lex:group[3]}"><xsl:value-of select="lex:group[1]"/></a>
</xsl:template>
Yeah, we should try to revert it and see what it gives. ;)
Paul, can you try?
salu2
--
Thorsten Scherler
COO Spain
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
thorsten.scherler@wyona.com thorsten@apache.org
Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "Gav...." <br...@brightontown.com.au>.
In pattern2link it says:-
<!--HEADSUP: thorsten changed this because we get working inline css and
for static reading it should not differ( one " ;" added).
was:
<a href="{lex:group[3]}"><xsl:value-of select="lex:group[1]"/></a
-->
----- Original Message -----
From: "Thorsten Scherler (JIRA)" <ji...@apache.org>
To: <de...@forrest.apache.org>
Sent: Tuesday, March 14, 2006 6:36 PM
Subject: [jira] Commented: (FOR-827) Weirdness in CSS after url
> [
> http://issues.apache.org/jira/browse/FOR-827?page=comments#action_12370332
> ]
>
> Thorsten Scherler commented on FOR-827:
> ---------------------------------------
>
>
> Well, not really that is an old feature of forrest.
> <map:match pattern="**.dispatcher.css">
> <map:generate src="cocoon:/resolve.structurer.{1}" type="jx">
> <map:parameter name="lenient-xpath" value="true" />
> <map:parameter name="getRequest" value="{1}" />
> <map:parameter name="getRequestExtension" value="css" />
> </map:generate>
> <map:transform type="dispatcher">
> <map:parameter name="request" value="{1}" />
> <map:parameter name="type" value="css" />
> </map:transform>
> <map:transform type="pattern"
> src="{forrest:context}/resources/chaperon/grammars/link.xlex" />
> <map:transform
>
> src="{forrest:context}/resources/chaperon/stylesheets/pattern2link.xsl"
> />
> <map:serialize type="text" mime-type="text/css" />
> </map:match>
>
> It is the link.xlex and pattern2link.xsl that is causing it. It actually
> should be the same in skins.
>
> See as well
> http://issues.apache.org/jira/browse/FOR-744
> http://issues.apache.org/jira/browse/FOR-745
>
>> Weirdness in CSS after url
>> --------------------------
>>
>> Key: FOR-827
>> URL: http://issues.apache.org/jira/browse/FOR-827
>> Project: Forrest
>> Type: Bug
>> Components: Dispatcher (aka views)
>> Versions: 0.8-dev
>> Reporter: paul bolger
>> Priority: Minor
>
>>
>> Don't quite understand were this is coming from. It appears that Forrest
>> is trying to improve on my stylesheets...
>> If a stylesheet contains a a URL, when referencing a background image in
>> this particular case, Forrest inserts an extra semicolon after the
>> closing bracket containing the URL. This is get-roundable normally, skip
>> the semicolon, but it prevent the use of the shorthand background
>> property as the semicolon truncates the rule.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.375 / Virus Database: 268.2.2/280 - Release Date: 13/03/2006
>
Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "Gav...." <br...@brightontown.com.au>.
oops, yes sorry.
Gav...
----- Original Message -----
From: "Thorsten Scherler" <th...@apache.org>
To: "Gav...." <br...@brightontown.com.au>
Cc: "forrest dev" <de...@forrest.apache.org>
Sent: Tuesday, March 14, 2006 7:20 PM
Subject: Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
> El mar, 14-03-2006 a las 19:12 +0800, Gav.... escribió:
>> The cssurl in link.xlex is looking at URL rather than in this case URI
>> isnt
>> it, or does it do both?
>
> ¿?
>
> background: url(...)
>
> it is looking for url. ;)
>
> salu2
> --
> thorsten
>
> "Together we stand, divided we fall!"
> Hey you (Pink Floyd)
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.375 / Virus Database: 268.2.2/280 - Release Date: 13/03/2006
>
Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by Thorsten Scherler <th...@apache.org>.
El mar, 14-03-2006 a las 19:12 +0800, Gav.... escribió:
> The cssurl in link.xlex is looking at URL rather than in this case URI isnt
> it, or does it do both?
¿?
background: url(...)
it is looking for url. ;)
salu2
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: [jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "Gav...." <br...@brightontown.com.au>.
The cssurl in link.xlex is looking at URL rather than in this case URI isnt
it, or does it do both?
Gav...
----- Original Message -----
From: "Thorsten Scherler (JIRA)" <ji...@apache.org>
To: <de...@forrest.apache.org>
Sent: Tuesday, March 14, 2006 6:36 PM
Subject: [jira] Commented: (FOR-827) Weirdness in CSS after url
> [
> http://issues.apache.org/jira/browse/FOR-827?page=comments#action_12370332
> ]
>
> Thorsten Scherler commented on FOR-827:
> ---------------------------------------
>
>
> Well, not really that is an old feature of forrest.
> <map:match pattern="**.dispatcher.css">
> <map:generate src="cocoon:/resolve.structurer.{1}" type="jx">
> <map:parameter name="lenient-xpath" value="true" />
> <map:parameter name="getRequest" value="{1}" />
> <map:parameter name="getRequestExtension" value="css" />
> </map:generate>
> <map:transform type="dispatcher">
> <map:parameter name="request" value="{1}" />
> <map:parameter name="type" value="css" />
> </map:transform>
> <map:transform type="pattern"
> src="{forrest:context}/resources/chaperon/grammars/link.xlex" />
> <map:transform
>
> src="{forrest:context}/resources/chaperon/stylesheets/pattern2link.xsl"
> />
> <map:serialize type="text" mime-type="text/css" />
> </map:match>
>
> It is the link.xlex and pattern2link.xsl that is causing it. It actually
> should be the same in skins.
>
> See as well
> http://issues.apache.org/jira/browse/FOR-744
> http://issues.apache.org/jira/browse/FOR-745
>
>> Weirdness in CSS after url
>> --------------------------
>>
>> Key: FOR-827
>> URL: http://issues.apache.org/jira/browse/FOR-827
>> Project: Forrest
>> Type: Bug
>> Components: Dispatcher (aka views)
>> Versions: 0.8-dev
>> Reporter: paul bolger
>> Priority: Minor
>
>>
>> Don't quite understand were this is coming from. It appears that Forrest
>> is trying to improve on my stylesheets...
>> If a stylesheet contains a a URL, when referencing a background image in
>> this particular case, Forrest inserts an extra semicolon after the
>> closing bracket containing the URL. This is get-roundable normally, skip
>> the semicolon, but it prevent the use of the shorthand background
>> property as the semicolon truncates the rule.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.375 / Virus Database: 268.2.2/280 - Release Date: 13/03/2006
>
[jira] Commented: (FOR-827) Weirdness in CSS after url
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-827?page=comments#action_12370332 ]
Thorsten Scherler commented on FOR-827:
---------------------------------------
Well, not really that is an old feature of forrest.
<map:match pattern="**.dispatcher.css">
<map:generate src="cocoon:/resolve.structurer.{1}" type="jx">
<map:parameter name="lenient-xpath" value="true" />
<map:parameter name="getRequest" value="{1}" />
<map:parameter name="getRequestExtension" value="css" />
</map:generate>
<map:transform type="dispatcher">
<map:parameter name="request" value="{1}" />
<map:parameter name="type" value="css" />
</map:transform>
<map:transform type="pattern"
src="{forrest:context}/resources/chaperon/grammars/link.xlex" />
<map:transform
src="{forrest:context}/resources/chaperon/stylesheets/pattern2link.xsl"
/>
<map:serialize type="text" mime-type="text/css" />
</map:match>
It is the link.xlex and pattern2link.xsl that is causing it. It actually should be the same in skins.
See as well
http://issues.apache.org/jira/browse/FOR-744
http://issues.apache.org/jira/browse/FOR-745
> Weirdness in CSS after url
> --------------------------
>
> Key: FOR-827
> URL: http://issues.apache.org/jira/browse/FOR-827
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views)
> Versions: 0.8-dev
> Reporter: paul bolger
> Priority: Minor
>
> Don't quite understand were this is coming from. It appears that Forrest is trying to improve on my stylesheets...
> If a stylesheet contains a a URL, when referencing a background image in this particular case, Forrest inserts an extra semicolon after the closing bracket containing the URL. This is get-roundable normally, skip the semicolon, but it prevent the use of the shorthand background property as the semicolon truncates the rule.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira