You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/23 18:57:46 UTC

[GitHub] [incubator-pinot] bxji commented on issue #4846: [TE] Refactor the fetch anomalies interface to incorporate detection id within the anomaly slice

bxji commented on issue #4846: [TE] Refactor the fetch anomalies interface to incorporate detection id within the anomaly slice
URL: https://github.com/apache/incubator-pinot/pull/4846#issuecomment-557823691
 
 
   Can we add a comment somewhere noting that configId and detectionId are referring to the same thing? We are using them interchangeably in the code, but it would not be clear to someone new to the codebase that they are the same. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org