You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/31 08:25:31 UTC
[GitHub] twalthr commented on a change in pull request #6966: [FLINK-10166]
[table] Reduce dependencies by removing org.apache.commons
twalthr commented on a change in pull request #6966: [FLINK-10166] [table] Reduce dependencies by removing org.apache.commons
URL: https://github.com/apache/flink/pull/6966#discussion_r229598889
##########
File path: flink-libraries/flink-table-common/src/main/java/org/apache/flink/table/utils/EncodingUtils.java
##########
@@ -40,14 +44,18 @@
private static final Base64.Decoder BASE64_DECODER = java.util.Base64.getUrlDecoder();
+ private static final MessageDigest MD5_MESSAGE_DIGEST = getMd5MessageDigest();
Review comment:
Usually this doesn't matter for translation (which is single threaded) but we are on the safer side if this method is thread-safe in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services