You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/10/31 12:37:10 UTC
[PR] feat(crd): Add default value trait in CRDs when declared in doc [camel-k]
gansheer opened a new pull request, #4887:
URL: https://github.com/apache/camel-k/pull/4887
Ref #4726
Improve CRDdetails:
* Add default value in CRDs for traits when declared in documentation and not conditional
* Add some validation for predictive values
* Some fixes in the traits documentation
**Release Note**
```release-note
feat(crd): Add default value trait in CRDs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(crd): Add default value trait in CRDs when declared in doc [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4887:
URL: https://github.com/apache/camel-k/pull/4887#issuecomment-1792108155
@gansheer it's not really required. It seems to be a single flaky test. If you confirm this is good to merge, I'll do straight away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(crd): Add default value trait in CRDs when declared in doc [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4887:
URL: https://github.com/apache/camel-k/pull/4887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(crd): Add default value trait in CRDs when declared in doc [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4887:
URL: https://github.com/apache/camel-k/pull/4887#issuecomment-1792129536
The PR is complete on my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(crd): Add default value trait in CRDs when declared in doc [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4887:
URL: https://github.com/apache/camel-k/pull/4887#issuecomment-1792092575
@squakez @oscerd could one of you please run again the failing tests ? 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org