Re: Review Request 37348: Fix Bug: Sqoop import query does not recognize the PK of IBM DB2 table.The Jira number is SQOOP-2328

[Jarek Cecho <ja...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37348/#review116150
-----------------------------------------------------------



Can we add test cases for the fix? I would like to make sure that we have the scenario covered, so that we won't regress in the future.

- Jarek Cecho


On Aug. 11, 2015, 9:09 a.m., Shashank Tandon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37348/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 9:09 a.m.)
> 
> 
> Review request for Sqoop and Venkat Ranganathan.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Currently Sqoop import query does not recognize the PK of IBM DB2 table.
> when any sqoop query is runs for DB2 table, it is not able to recognize the primary key(PK) of that table, which is used as --split-by column implicitly. And it becomes mandatory to give --split-by <colname> explicitly in the sqoop query. This is fixed in this sqoop patch.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c 
> 
> Diff: https://reviews.apache.org/r/37348/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Shashank Tandon
> 
>