You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/08/11 07:25:40 UTC

[GitHub] [calcite] paul8263 opened a new pull request #2481: [CALCITE-4725] Between clause operands checker should check all combi…

paul8263 opened a new pull request #2481:
URL: https://github.com/apache/calcite/pull/2481


   …nations of the three operands
   
   ## What is the purpose of the change
   
   Fix the issue that between clause operands checker should check all combinations of the three operands, as what has been discuss in CALCITE-4725 in ASF Jira.
   
   ## Brief change log
   
   - core/src/main/java/org/apache/calcite/sql/type/SameOperandTypeChecker.java
   - core/src/main/java/org/apache/calcite/sql/type/SameOperandTypeExceptLastOperandChecker.java 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] NobiGo commented on pull request #2481: [CALCITE-4725] Between clause operands checker should check all combi…

Posted by GitBox <gi...@apache.org>.
NobiGo commented on pull request #2481:
URL: https://github.com/apache/calcite/pull/2481#issuecomment-896635238


   @paul8263  please add unit test in this patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] paul8263 commented on pull request #2481: [CALCITE-4725] Between clause operands checker should check all combi…

Posted by GitBox <gi...@apache.org>.
paul8263 commented on pull request #2481:
URL: https://github.com/apache/calcite/pull/2481#issuecomment-897297645


   Hi @NobiGo ,
   Thank you for your advice. Unit test has been added and several errors have been fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] paul8263 commented on pull request #2481: [CALCITE-4725] Between clause operands checker should check all combi…

Posted by GitBox <gi...@apache.org>.
paul8263 commented on pull request #2481:
URL: https://github.com/apache/calcite/pull/2481#issuecomment-1073412282


   Hi @NobiGo ,
   Could you please help review this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org