[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #30: [FLINK-26247] Optimize expire by only reading new changes in a snapshot

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #30:
URL: https://github.com/apache/flink-table-store/pull/30#discussion_r817471690



##########
File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java
##########
@@ -316,24 +318,35 @@ private boolean tryCommitOnce(
                             manifestFile,
                             manifestTargetSize.getBytes(),
                             manifestMergeMinCount));
+            previousChangesListName = manifestList.write(newMetas);
+
             // write new changes into manifest files
+            List<ManifestFileMeta> newChangesManifests = new ArrayList<>();
             if (!changes.isEmpty()) {
-                newMetas.addAll(manifestFile.write(changes));
+                newChangesManifests.addAll(manifestFile.write(changes));

Review comment:
       `manifestFile.write` supports empty entries?

##########
File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/Snapshot.java
##########
@@ -44,8 +45,14 @@
     @JsonProperty(FIELD_ID)
     private final long id;
 
-    @JsonProperty(FIELD_MANIFEST_LIST)
-    private final String manifestList;
+    // a manifest list recording all changes from the previous snapshots
+    @JsonProperty(FIELD_PREVIOUS_CHANGES)
+    private final String previousChanges;

Review comment:
       `baseManifestList` and `deltaManifestList`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org