You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/10/20 00:02:26 UTC
Review Request 63175: Do not generate UnavailableResources for
inactive frameworks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63175/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Bugs: MESOS-8085
https://issues.apache.org/jira/browse/MESOS-8085
Repository: mesos
Description
-------
Do not generate UnavailableResources for inactive frameworks.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp c2346054b2c98516f15ab8ce2dc798224ff4def4
src/master/allocator/mesos/hierarchical.cpp 5b6efe5faa3c3b10f1f714f582a155b368f8ccaf
Diff: https://reviews.apache.org/r/63175/diff/1/
Testing
-------
make check.
I didn' write a new test as the externally observable behavior doesn't change.
Thanks,
Jiang Yan Xu
Re: Review Request 63175: Do not generate UnavailableResources for
inactive frameworks.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63175/#review188824
-----------------------------------------------------------
PASS: Mesos patch 63175 was successfully built and tested.
Reviews applied: `['63175']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63175
- Mesos Reviewbot Windows
On Oct. 20, 2017, 12:02 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63175/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 12:02 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-8085
> https://issues.apache.org/jira/browse/MESOS-8085
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not generate UnavailableResources for inactive frameworks.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp c2346054b2c98516f15ab8ce2dc798224ff4def4
> src/master/allocator/mesos/hierarchical.cpp 5b6efe5faa3c3b10f1f714f582a155b368f8ccaf
>
>
> Diff: https://reviews.apache.org/r/63175/diff/1/
>
>
> Testing
> -------
>
> make check.
>
> I didn' write a new test as the externally observable behavior doesn't change.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 63175: Do not generate UnavailableResources for
inactive frameworks.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63175/#review188823
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63175]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 20, 2017, 12:02 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63175/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 12:02 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-8085
> https://issues.apache.org/jira/browse/MESOS-8085
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not generate UnavailableResources for inactive frameworks.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp c2346054b2c98516f15ab8ce2dc798224ff4def4
> src/master/allocator/mesos/hierarchical.cpp 5b6efe5faa3c3b10f1f714f582a155b368f8ccaf
>
>
> Diff: https://reviews.apache.org/r/63175/diff/1/
>
>
> Testing
> -------
>
> make check.
>
> I didn' write a new test as the externally observable behavior doesn't change.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>