You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zommerfelds <gi...@git.apache.org> on 2016/06/02 14:19:22 UTC

[GitHub] spark pull request #13467: [SPARK-15642][SQL][WIP] Added test case

GitHub user zommerfelds opened a pull request:

    https://github.com/apache/spark/pull/13467

    [SPARK-15642][SQL][WIP] Added test case

    WORK IN PROGRESS
    https://issues.apache.org/jira/browse/SPARK-15642
    
    Added test case to show the described bug. I am not sure if this is expected behaviour or not, please comment.
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zommerfelds/spark spark-15642

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13467
    
----
commit acb4b067ed97834f782bd60cb726f68a78f90e26
Author: zommerfelds <ae...@yahoo.com>
Date:   2016-06-02T14:14:04Z

    [SPARK-15642][SQL] Added test case

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Metadata gets lost when selectin...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #13467: [SPARK-15642][SQL] Bug report: metadata gets lost...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/13467


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Metadata gets lost when selectin...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    Hi @zommerfelds, do you mind if I ask whether you still working on this? It seems inactive for more than a half year. Maybe, it'd be better closed for now if you are currently not able to work on this further.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Metadata gets lost when selectin...

Posted by zommerfelds <gi...@git.apache.org>.
Github user zommerfelds commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    Hi @HyukjinKwon, I never worked on the fix, because I never got confirmation if this is actually a bug or not. This PR demonstrates the bug I posted on Jira.
    If you want I can try to find out if this is still present in the most recent version of Spark.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Metadata gets lost when selectin...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Metadata gets lost when selectin...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    Aha, then to be strict, it is not WIP but just waiting the feedback. How about closing this and pinging related guys who touched this code path lately in the JIRA?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Added test case

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Metadata gets lost when selectin...

Posted by zommerfelds <gi...@git.apache.org>.
Github user zommerfelds commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    Sure, I agree, I think at the time putting the label seemed to be
    reasonable, after reading the documentation.
    
    I will check and see if this error is still present. How would I go about
    pinging related people? Git blame and search if they are on Jira?
    
    On Sat, Feb 11, 2017, 07:08 Hyukjin Kwon <no...@github.com> wrote:
    
    > Aha, then to be strict, it is not WIP but just waiting the feedback. How
    > about closing this and pinging related guys who touched this code path
    > lately in the JIRA?
    >
    > \u2014
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/13467#issuecomment-279139846>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/ABM8TsnEd30hcsyf8TTRjouZHJbnY486ks5rbaSpgaJpZM4Ismt->
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Metadata gets lost when selectin...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    Yes, exactly. That's usually I do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13467: [SPARK-15642][SQL] Bug report: metadata gets lost when s...

Posted by zommerfelds <gi...@git.apache.org>.
Github user zommerfelds commented on the issue:

    https://github.com/apache/spark/pull/13467
  
    The bug is still present. To be honest I don't think I have time to work on this right now, so we can close this PR if you want. I tried to find the code that was related to this functionality but didn't get there yet, so not sure who to contact. Someone might be able to tell really fast if this is a bug or not, and what has to be done to fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org